-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conformance metadata release 1.20 #99081
Fix conformance metadata release 1.20 #99081
Conversation
@heyste: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig architecture |
/test pull-kubernetes-node-e2e
|
/area conformance |
/sig scheduling |
/test pull-kubernetes-integration
|
/test pull-kubernetes-e2e-kind
Common error: tests taking to long, |
/test pull-kubernetes-e2e-gce-ubuntu-containerd
|
/test pull-kubernetes-e2e-kind
Common error: tests taking to long, |
/test pull-kubernetes-e2e-kind |
What is the process for making changes to conformance tests? Should we update some other file in sonobuoy so that there is no drift between what sonobuoy expects and what is available in main or release branch of k/k? |
To be clear, this test filter change should not impact Sonobuoy the project itself (as sonobuoy simply passes specified test filter directly to the e2e test binary). However, if Sonobuoy is being used in a build pipeline for conformance with a specified set of filters, this change will impact the use of Sonobouy. |
/cc |
cc: @kubernetes/release-engineering |
Couple questions:
|
@jsturtevant this is not a new test, it existed in 1.19 as well, what changed? We did fix a specific issue related to this test, where it was previously (in 1.19 and earlier) not checking if the actual ports we wired up correctly. Did that cause issues for Windows? |
As discussed on slack we could exclude it in our 1.20 tests. The updates to in 1.21 (#98299) don't cause issues that I have seen so far |
@spiffxp @johnbelamaric we need this to merge in time for the next 1.20.x release. The problem is that we are getting reports from folks submitting CNCF conformance reports and the CI there is logging this as a failure. We should also pay attention on merging changes to this yaml going forward in the release branches. @kubernetes/release-managers |
/approve |
After discussing with @jsturtevant, SIG windows will deal with skipping this on their own, so we can revert. /approve |
/approve |
/release-note-none |
For RelEng: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, heyste, johnbelamaric, justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
#98940 addressed a SIG-Scheduling conformance test that was relocated to SIG-Network by tagging those changes to be part of the 1.21 release. This PR reverts changes made to the 1.20 release conformance metadata which is causing k8s-conformance tests to fail at the moment.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: