Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #99463: Use Lstat in plugin watcher to avoid Windows problem #99723: Fix issue in checking domain socket for plugin watcher #99745

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Automated cherry pick of #99463: Use Lstat in plugin watcher to avoid Windows problem #99723: Fix issue in checking domain socket for plugin watcher #99745

merged 2 commits into from
Mar 11, 2021

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Mar 4, 2021

Cherry pick of #99463 #99723 on release-1.19.

#99463: Use Lstat in plugin watcher to avoid Windows problem
#99723: Fix issue in checking domain socket for plugin watcher

For details on the cherry pick process, see the cherry pick requests page.

jingxu97 added 2 commits March 3, 2021 17:23
@jingxu97
Use Lstat in plugin watcher to avoid Windows problem
8ad60e7 
User Lstat in plugin watcher due to Windows issue

Change-Id: I4f9b808829f1a56dc622e343c291d3ffc316f416
@jingxu97
Fix issue in checking domain socket for plugin watcher
649159d 
    Due to recent os.Stat() issue for Windows 20H2, added the logic to use
    os.Lstat() if os.Stat() fails for Windows

Change-Id: Ic9fc07ecc6e9c2984e854ac77121ff61c8e0d041
@k8s-ci-robot
Copy link
Contributor

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2021
@jeremyje
Copy link
Contributor

jeremyje commented Mar 4, 2021

/lgtm
/approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
saad-ali
saad-ali approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, jingxu97, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@jingxu97 jingxu97 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 4, 2021
@jingxu97 jingxu97 removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 4, 2021
@jingxu97
Copy link
Contributor Author

jingxu97 commented Mar 4, 2021

/assign @kubernetes/release-engineering @kubernetes/release-managers

@jeremyje
Copy link
Contributor

jeremyje commented Mar 8, 2021

/lgtm
/approval

@ehashman
Copy link
Member

ehashman commented Mar 8, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2021
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 11, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8b66415 into kubernetes:release-1.19 Mar 11, 2021
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 26, 2022
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyje jeremyje jeremyje approved these changes

@saad-ali saad-ali saad-ali approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@jeremyje jeremyje

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@jingxu97 @k8s-ci-robot @jeremyje @ehashman @fejta-bot @saad-ali @feiskyer @liggitt