Add warning for --network-plugin=cni (CNI has to be provided, see --cni)

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
kubernetes · Oct 12, 2020 · 1d85d6e · 1d85d6e
1 parent 2823462
commit 1d85d6e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/cmd/minikube/cmd/start_flags.go b/cmd/minikube/cmd/start_flags.go
@@ -276,6 +276,11 @@ func generateClusterConfig(cmd *cobra.Command, existing *config.ClusterConfig, k
 			glog.Errorf("Found deprecated --enable-default-cni flag, setting --cni=bridge")
 			chosenCNI = "bridge"
 		}
+		// networkPlugin cni deprecation warning
+		chosenNetworkPlugin := viper.GetString(networkPlugin)
+		if chosenNetworkPlugin == "cni" {
+			out.WarningT("With --network-plugin=cni, you will need to provide your own CNI. See --cni flag as a user-friendly alternative")
+		}
 
 		cc = config.ClusterConfig{
 			Name:                    ClusterFlagValue(),
@@ -321,7 +326,7 @@ func generateClusterConfig(cmd *cobra.Command, existing *config.ClusterConfig, k
 				FeatureGates:           viper.GetString(featureGates),
 				ContainerRuntime:       viper.GetString(containerRuntime),
 				CRISocket:              viper.GetString(criSocket),
-				NetworkPlugin:          viper.GetString(networkPlugin),
+				NetworkPlugin:          chosenNetworkPlugin,
 				ServiceCIDR:            viper.GetString(serviceCIDR),
 				ImageRepository:        repository,
 				ExtraOptions:           config.ExtraOptions,