Skip to content

Commit

Permalink
Update create secret in service so registry creds add on does not fai…
Browse files Browse the repository at this point in the history
…l when a secret does not exist.
  • Loading branch information
akshay-subram committed Jan 28, 2020
1 parent 5fa7935 commit 2ba3116
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/minikube/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,11 @@ func CreateSecret(namespace, name string, dataValues map[string]string, labels m
if err != nil {
return &retry.RetriableError{Err: err}
}

secrets := client.Secrets(namespace)
secret, err := secrets.Get(name, meta.GetOptions{})
if err != nil {
return &retry.RetriableError{Err: err}
glog.Infof("Failed to retrieve existing secret: %v", err)
}

// Delete existing secret
Expand Down

0 comments on commit 2ba3116

Please sign in to comment.