Skip to content

Commit

Permalink
dont check exit code of minikube logs in logs duration test
Browse files Browse the repository at this point in the history
  • Loading branch information
spowelljr committed May 4, 2021
1 parent 29a6825 commit 459c42b
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions test/integration/aaa_download_only_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,12 @@ func TestDownloadOnly(t *testing.T) {
}
})

t.Run("minikube logs", func(t *testing.T) {
// checks if the duration of `minikube logs` takes longer than 5 seconds
t.Run("LogsDuration", func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), Seconds(5))
defer cancel()
args := []string{"logs", "-p", profile}
if _, err := Run(t, exec.CommandContext(ctx, Target(), args...)); err != nil {
t.Errorf("minikube logs failed with error: %v", err)
}
Run(t, exec.CommandContext(ctx, Target(), args...))
if err := ctx.Err(); err == context.DeadlineExceeded {
t.Error("minikube logs expected to finish by 5 seconds, but took longer")
}
Expand Down

0 comments on commit 459c42b

Please sign in to comment.