Skip to content

Commit

Permalink
Merge pull request #6315 from medyagh/istio_disable
Browse files Browse the repository at this point in the history
disable istio provisioner by default
  • Loading branch information
sharifelgamal authored Jan 14, 2020
2 parents 8e51307 + 577a04b commit 70f73e7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
16 changes: 11 additions & 5 deletions deploy/addons/istio/README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
## istio Addon
[istio](https://istio.io/docs/setup/getting-started/) - Cloud platforms provide a wealth of benefits for the organizations that use them.

### Enabling istio
Propose to startup minikube with at least 8192 MB of memory and 4 CPUs to enable istio.
To enable this addon, simply run:
### Enable istio on minikube
Make sure to start minikube with at least 8192 MB of memory and 4 CPUs.

```shell script
minikube start --memory=8000mb --cpus=4
```

To enable this addon, simply run:
```shell script
minikube addons enable istio-provisioner
minikube addons enable istio
```

Expand All @@ -19,8 +24,9 @@ kubectl get po -n istio-system

If everything went well you shouldn't get any errors about istio being installed in your cluster. If you haven't deployed any releases `kubectl get po -n istio-system` won't return anything.

### Deprecation of istio
### Disable istio
To disable this addon, simply run:
```shell script
minikube addons disable istio-provisioner
minikube addons disable istio
```
```
2 changes: 1 addition & 1 deletion pkg/minikube/assets/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ var Addons = map[string]*Addon{
"istio-operator.yaml",
"0640",
true),
}, true, "istio-provisioner"),
}, false, "istio-provisioner"),
"istio": NewAddon([]*BinAsset{
MustBinAsset(
"deploy/addons/istio/istio-default-profile.yaml.tmpl",
Expand Down

0 comments on commit 70f73e7

Please sign in to comment.