-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential profile naming conflict with multi-node cluster. #10061
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Comments
@daehyeok that is definatly a problem, and I think we should not allow that, how aboutt adding a check in our validate profile name that we already do, to ensure this doesnt happen ? |
medyagh
added
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
labels
Dec 29, 2020
Sure. Give me some time :) |
Hey guys, same problem here, is there an solution? Downgrade docker for example?
Cheers Ralf |
@homeoftheunits |
daehyeok
added a commit
to daehyeok/minikube
that referenced
this issue
Jan 9, 2021
Check profile and node name before add to prevent conflict with machine name on multinode cluster. Fixes kubernetes#10061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Minikube doesn't have a restriction on profile name. It have a potential conflict with multi-node cluster.
E.g) create test-profile with multiple node will fail if test-profile-m02 profile already exists.
Naming rule for profile or check routine should be added before create new profile(node).
The text was updated successfully, but these errors were encountered: