Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/handbook: don't advise users to create a symbolic link to minikube’s binary named ‘kubectl’ #10717

Closed
prezha opened this issue Mar 4, 2021 · 3 comments · Fixed by #10732
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@prezha
Copy link
Contributor

prezha commented Mar 4, 2021

this confuses users and doesn't work (eg, minikube calling kubectl would loopback to itself)
ref: https://minikube.sigs.k8s.io/docs/handbook/kubectl/ (https://github.com/kubernetes/minikube/blob/master/site/content/en/docs/handbook/kubectl.md)

Alternatively, you can create a symbolic link to minikube’s binary named ‘kubectl’.

ln -s $(which minikube) /usr/local/bin/kubectl

example: #9976

previously, there were discussions in issue #8857 and pr #8872

alternatively, we can make it work by 'recognising' that minikube was called as kubectl and assign the flags as flags for minikube's own downloaded kubectl binary...

@ilya-zuyev ilya-zuyev added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 4, 2021
@medyagh
Copy link
Member

medyagh commented Mar 4, 2021

good idea, needs fix

@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 5, 2021

It would be better to fix the feature, for whatever it is that is broken ?

For me, I think it is just that it has a bunch of cluster checks now... (instead of just calling the binary)

$ kubectl version --client --output=json
🤷  Profile "minikube" not found. Run "minikube profile list" to view all profiles.
👉  To start a cluster, run: "minikube start"

It was only supposed to check the kubernetes version of the profile.

@afbjorklund
Copy link
Collaborator

I think it was broken in 8f9a2b9, that added the mustload.Healthy

@afbjorklund afbjorklund removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants