Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run internal kubectl when os.Args[0] is 'kubectl' #8857

Closed
drewpca opened this issue Jul 27, 2020 · 3 comments
Closed

run internal kubectl when os.Args[0] is 'kubectl' #8857

drewpca opened this issue Jul 27, 2020 · 3 comments
Labels
cmd/kubectl Issues with the "kubectl" command help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@drewpca
Copy link

drewpca commented Jul 27, 2020

It would be nice if this worked:

% sudo install minikube-linux-amd64 /usr/local/bin/minikube
% sudo ln -s /usr/local/bin/minikube /usr/local/bin/kubectl
% kubectl version

No harm to existing workflows (as long as we don't force the creation of that symlink-- see k3s-io/k3s#521), and it would save on aliases and '--' argument separators.

Related: #4684
Related: #4697
@sharifelgamal sharifelgamal added cmd/kubectl Issues with the "kubectl" command help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 28, 2020
kadern0 added a commit to kadern0/minikube that referenced this issue Jul 29, 2020
@kadern0
Running internal kubectl command when minikube is called as 'kubectl'
f72d295 
Fixes issue kubernetes#8857

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@kadern0 kadern0 mentioned this issue Jul 29, 2020
Merged
kadern0 added a commit to kadern0/minikube that referenced this issue Jul 29, 2020
@kadern0
Running internal kubectl command when minikube is called as 'kubectl'
f42bdcf 
Fixes issue kubernetes#8857

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
kadern0 added a commit to kadern0/minikube that referenced this issue Aug 2, 2020
@kadern0
Running internal kubectl command when minikube is called as 'kubectl'
b46e753 
Fixes issue kubernetes#8857

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@afbjorklund
Copy link
Collaborator

I like this suggestion, we talked about our solutions like providing an "--install" flag or echoing the program path.

@drewpca drewpca mentioned this issue Aug 14, 2020
Closed
kadern0 added a commit to kadern0/minikube that referenced this issue Aug 17, 2020
@kadern0
Running internal kubectl command when minikube is called as 'kubectl'
10a3f2e 
Fixes issue kubernetes#8857

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@kadern0
Copy link
Contributor

kadern0 commented Sep 2, 2020

@sharifelgamal this has been fixed with #8872

@sharifelgamal
Copy link
Collaborator

Excellent, thank you!

@prezha prezha mentioned this issue Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/kubectl Issues with the "kubectl" command help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drewpca @afbjorklund @kadern0 @sharifelgamal