Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Option for registry-creds #1253

Closed
Teddy-Schmitz opened this issue Mar 17, 2017 · 2 comments
Closed

Additional Option for registry-creds #1253

Teddy-Schmitz opened this issue Mar 17, 2017 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Teddy-Schmitz
Copy link
Contributor

I would like to add an additional config option to the addon setup prompts that show up when you enable registry-creds. Specifically I would like the option to set the gcr-url to something other then the default without having to edit the replication controller.

I'm happy to do a PR on this if thats ok.

@aaron-prindle
Copy link
Contributor

We will gladly accept a PR for this. Currently the gcr-url is a CLI arg into the addon:
https://github.com/upmc-enterprises/registry-creds/blob/master/main.go#L57

The code for the prompt to input parameters into the addon is here:

enableGCR := AskForYesNoConfirmation("\nDo you want to enable Google Container Registry?", posResponses, negResponses)

You should be able to edit the addon to take a Config Map that passes the gcr-url parameter as a command line arg:
https://kubernetes.io/docs/user-guide/configmap/

@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 17, 2017
@Teddy-Schmitz
Copy link
Contributor Author

Great, I'll start with adding the config map option to the addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants