-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcrurl env var to registry-creds addon deployment and configuration #1436
Add gcrurl env var to registry-creds addon deployment and configuration #1436
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
CLA signed. |
@minikube-bot ok to test |
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
=======================================
Coverage 41.97% 41.97%
=======================================
Files 49 49
Lines 2356 2356
=======================================
Hits 989 989
Misses 1205 1205
Partials 162 162 Continue to review full report at Codecov.
|
When I run this locally I seem to get an error pulling an image from gcr (hosted at https://gcr.io) when attempting to use the default gcr-url. When attempting the same action on the current version of minikube/registry-creds I do not get the same error. |
Hey, |
@Teddy-Schmitz do you happen to know if the image was updated? I think that 1.7 is still the latest pushed image. |
Thanks for this! A new image was pushed and we recently updated the image to 1.8. Merging. |
Hello,
This is related to issue #1253 . It will also require the newer version of registry-creds which I'm happy to amend to this PR when a new version is cut. I want to make sure the other changes are OK first.
This is my first time contributing to the minikube project so please let me know if I missed something I was supposed to do.
Thanks!