Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ~ in --ssh-key causes SSH key does not exist #12659

Closed
spowelljr opened this issue Oct 5, 2021 · 2 comments · Fixed by #12672
Closed

Using ~ in --ssh-key causes SSH key does not exist #12659

spowelljr opened this issue Oct 5, 2021 · 2 comments · Fixed by #12672
Assignees
@marcvelasco
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@spowelljr
Copy link
Member

spowelljr commented Oct 5, 2021 •
edited
Loading 

$minikube start ... --ssh-key=~/.ssh/id_rsa
...
🤦  StartHost failed, but will try again: creating host: create: precreate: SSH key does not exist: "~/.ssh/id_rsa"

The weird quirk is this only occurs if you use an = between the key pair, if you use a space your terminal will rewrite to the absolute path.

$ echo ~/.ssh
/Users/user/.ssh

$ echo --ssh-key=~/.ssh
--ssh-key=~/.ssh

We should update the ssh-key value with the absolute path if we detect a ~.
@spowelljr spowelljr added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 5, 2021
@spowelljr spowelljr mentioned this issue Oct 5, 2021
Closed
@marcvelasco
Copy link
Contributor

Can I take a look at this one?
/assign

@spowelljr
Copy link
Member Author

@marcvelasco Yup, go ahead!

@marcvelasco marcvelasco mentioned this issue Oct 7, 2021
Closed
marcvelasco added a commit to marcvelasco/minikube that referenced this issue Oct 7, 2021
@marcvelasco
fix for kubernetes#12659, rendor absolute path when tilde starts ssh-…
c27326c 
…key path
@marcvelasco marcvelasco mentioned this issue Oct 7, 2021
Merged
spowelljr added a commit that referenced this issue Oct 7, 2021
@spowelljr
Merge pull request #12672 from marcvelasco/mvelasc-patch-2
c03ffa5 
fix for #12659, utilize absolute path when tilde starts ssh-key path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcvelasco marcvelasco

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
2 participants
@marcvelasco @spowelljr