Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest removal of old beta keyword in storageclass.yaml #4148

Closed
redmcg opened this issue Apr 24, 2019 · 3 comments
Closed

Suggest removal of old beta keyword in storageclass.yaml #4148

redmcg opened this issue Apr 24, 2019 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@redmcg
Copy link

redmcg commented Apr 24, 2019

This is an issue proposing a pull request (as requested in the Contributing guidelines) - but the PR is pretty simple.

In storageclass.yaml, the is-default-class annotation is still using the old beta variant:
storageclass.beta.kubernetes.io/is-default-class: "true"

The proposal it to remove the beta keyword.
@tstromberg
Copy link
Contributor

Sounds great. Please open a PR at your leisure.

@tstromberg tstromberg added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 25, 2019
@keramiozsoy keramiozsoy mentioned this issue Apr 25, 2019
Merged
@keramiozsoy
Copy link
Contributor

Hi I deleted , #4153

@redmcg
Copy link
Author

redmcg commented Apr 27, 2019

I'll close this and follow #4153. Please re-open if the preference is to track via an issue as well as PR.

@redmcg redmcg closed this as completed Apr 27, 2019
tstromberg added a commit that referenced this issue Apr 30, 2019
@tstromberg
Merge pull request #4153 from keramiozsoy/storageclass-its-no-longer-…
fce1578 
…beta

storageclass no longer beta #4148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstromberg @keramiozsoy @redmcg