Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem detection for docker start failures #4273

Closed
tstromberg opened this issue May 16, 2019 · 4 comments
Closed

Add problem detection for docker start failures #4273

tstromberg opened this issue May 16, 2019 · 4 comments
Labels
co/runtime/docker Issues specific to a docker runtime help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

See #4231 for an example.

@tstromberg tstromberg added co/docker-env docker-env issues kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. co/runtime/docker Issues specific to a docker runtime r/2019q2 Issue was last reviewed 2019q2 and removed co/docker-env docker-env issues labels May 23, 2019
@fenglixa
Copy link
Contributor

@tstromberg I was able to duplicate this issue. But I am sorry, could you please clarify more about what behavior is expected for this ticket? Thanks very much!

BR
-Francis

@fenglixa
Copy link
Contributor

fenglixa commented Jun 3, 2019

Current behavior of starting docker is ahead of configuring, which mean this issue was already addressed?
As following:

~/Documents/GitHub/minikube_fengli:$ sudo minikube start --registry-mirror registry.cn-hangzhou.aliyuncs.com/google_containers -p registry-mirror
😄  minikube v1.1.0 on darwin (amd64)
🔥  Creating virtualbox VM (CPUs=2, Memory=2048MB, Disk=20000MB) ...

💣  Failed to enable container runtime: command failed: sudo systemctl start docker
stdout:
stderr: Job for docker.service failed because the control process exited with error code.
See "systemctl status docker.service" and "journalctl -xe" for details.
: Process exited with status 1

😿  Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉  https://github.com/kubernetes/minikube/issues/new

@afbjorklund
Copy link
Collaborator

I think the idea is to give a more helpful error message, when you use --registry-mirror without a scheme.

  --image-repository string           Alternative image repository to pull docker images from.

This can be used when you have limited access to gcr.io. Set it to "auto" to let minikube decide one for you. For Chinese mainland users, you may use local gcr.io mirrors such as registry.cn-hangzhou.aliyuncs.com/google_containers

  --registry-mirror strings           Registry mirrors to pass to the Docker daemon
   --registry-mirror=<scheme>://<host>

Prepend a registry mirror to be used for image pulls. May be specified multiple times.

Maybe even suggest "did you mean --image-repository", if it doesn't contain a :// and specify a scheme ?

@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 18, 2019
@tstromberg tstromberg removed the r/2019q2 Issue was last reviewed 2019q2 label Sep 20, 2019
@priyawadhwa
Copy link

Looks like a more helpful registry-mirror error message was included in #4284, so I'm going to go ahead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/docker Issues specific to a docker runtime help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants