Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for --registry-mirror flag #4284

Merged
merged 5 commits into from
Jun 26, 2019
Merged

Added validation for --registry-mirror flag #4284

merged 5 commits into from
Jun 26, 2019

Conversation

hpandeycodeit
Copy link

This will close Issue #4274

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2019
medyagh
medyagh requested changes May 20, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add unit test for a few valid and Invalid registery mirrors?

tstromberg
tstromberg suggested changes May 22, 2019
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 22, 2019
@hpandeycodeit
Copy link
Author

hpandeycodeit commented May 22, 2019 •
edited
Loading

@minikube-bot ok to test

@hpandeycodeit
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 24, 2019
medyagh
medyagh requested changes May 28, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit tests

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
medyagh
medyagh reviewed Jun 4, 2019
View reviewed changes
cmd/minikube/cmd/start.go Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@medyagh medyagh mentioned this pull request Jun 5, 2019
Closed
6 tasks
@medyagh
Copy link
Member

medyagh commented Jun 14, 2019

@hpandeycodeit labeling the PR as work in progress, please let me know if you are still working on this

@medyagh medyagh added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hpandeycodeit
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hpandeycodeit
Copy link
Author

@hpandeycodeit labeling the PR as work in progress, please let me know if you are still working on this

Just made some changes as you have suggested. Let me know if anything else needs to be addressed :)

@medyagh medyagh merged commit 904bc49 into kubernetes:master Jun 26, 2019
@medyagh medyagh mentioned this pull request Aug 21, 2019
Closed
@priyawadhwa priyawadhwa mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg requested changes

@medyagh medyagh medyagh requested changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hpandeycodeit @minikube-bot @medyagh @k8s-ci-robot @tstromberg