You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for a better unifying experience, we need to handle ssh commands for kic as well
// RunSSHCommandFromDriver implements direct ssh control to the driver
func (d *Driver) RunSSHCommandFromDriver() error {
return fmt.Errorf("driver does not support RunSSHCommandFromDriver commands")
}
I suspect we might need to implement a NewBuildrootProvisioner
alternatively we could make a factory that Turns a kic runner to machine-driver's ssh.Cllient
but that would loos all the nice interface we have for command runner to set stdin and stdout and we need to convert to this interface:
type Client interface {
Output(command string) (string, error)
Shell(args ...string) error
// Start starts the specified command without waiting for it to finish. You
// have to call the Wait function for that.
//
// The first two io.ReadCloser are the standard output and the standard
// error of the executing command respectively. The returned error follows
// the same logic as in the exec.Cmd.Start function.
Start(command string) (io.ReadCloser, io.ReadCloser, error)
// Wait waits for the command started by the Start function to exit. The
// returned error follows the same logic as in the exec.Cmd.Wait function.
Wait() error
}
for a better unifying experience, we need to handle ssh commands for kic as well
I suspect we might need to implement a NewBuildrootProvisioner
the current one uses https://github.com/machine-drivers/machine
The text was updated successfully, but these errors were encountered: