Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic driver: add multiple profiles and ssh #6390

Merged
merged 11 commits into from
Jan 24, 2020
Merged

kic driver: add multiple profiles and ssh #6390

merged 11 commits into from
Jan 24, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jan 24, 2020 •
edited
Loading

This PR:

  • enables "minikube ssh" functionality for kic drivers
  • enables multiple profiles for kic
  • new kic base image with openssh installed in it

closes #6304 and #6388

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2020
@medyagh medyagh requested a review from tstromberg January 24, 2020 03:22
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@codecov-io
Copy link

Codecov Report

Merging #6390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6390   +/-   ##
======================================
  Coverage    38.3%   38.3%           
======================================
  Files         124     124           
  Lines        8355    8355           
======================================
  Hits         3200    3200           
  Misses       4737    4737           
  Partials      418     418

@medyagh medyagh changed the title wip: add SSH to kic kic multiple profiles and ssh Jan 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2020
@medyagh
Copy link
Member Author

medyagh commented Jan 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 24, 2020
@medyagh medyagh changed the title kic multiple profiles and ssh kic driver: add multiple profiles and ssh functionality Jan 24, 2020
@medyagh medyagh changed the title kic driver: add multiple profiles and ssh functionality kic driver: add multiple profiles and ssh Jan 24, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@tstromberg tstromberg merged commit 82e096a into kubernetes:master Jan 24, 2020
@medyagh medyagh mentioned this pull request Jan 25, 2020
Closed
@medyagh medyagh deleted the kic_bindip branch May 2, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kic: support multiple profiles
5 participants
@medyagh @k8s-ci-robot @codecov-io @minikube-pr-bot @tstromberg