Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add control-plane to NO_PROXY for docker/podman drivers #10046

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

lingsamuel
Copy link
Contributor

@lingsamuel lingsamuel commented Dec 24, 2020

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

We should make sure api endpoint exists in NO_PROXY.

With noProxy in .docker/config.json:
image

without noProxy in .docker/config.json:
image

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @lingsamuel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 24, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lingsamuel
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 29, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lingsamuel thank you very much for this PR,

do u mind pasting the out of minikube after this PR. and verify that the proxy env was added ?

to do that u can do

make kic-base-image
minikube start --base-image="...the name of the image that was produced in last step...which starts with local/kicbase..."
then u can do

minikube ssh
and cat the systemfile to show that it is there

@lingsamuel
Copy link
Contributor Author

added

@lingsamuel lingsamuel requested a review from medyagh December 30, 2020 03:59
@lingsamuel lingsamuel closed this Dec 31, 2020
@lingsamuel lingsamuel deleted the no_proxy branch December 31, 2020 04:36
@lingsamuel lingsamuel restored the no_proxy branch December 31, 2020 04:36
@lingsamuel lingsamuel reopened this Dec 31, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this

@medyagh medyagh merged commit 02b770c into kubernetes:master Dec 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingsamuel, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2020
@medyagh medyagh changed the title Kic: make sure NO_PROXY contains api endpoint docker/podman drivers: add control-plane to NO_PROXY Dec 31, 2020
@medyagh medyagh changed the title docker/podman drivers: add control-plane to NO_PROXY add control-plane to NO_PROXY for docker/podman drivers Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants