Add new flag --user and to log executed commands

[spowelljr]

Implements #10041

Example log:

% cat .minikube/logs/audit.json
{"data":{"args":"--user user1","command":"start","endTime":"Thu, 14 Jan 2021 16:21:04 MST","profile":"minikube","startTime":"Thu, 14 Jan 2021 16:20:18 MST","user":"user1"},"datacontenttype":"application/json","id":"042ad16a-79fe-461d-aec7-375c413c52f8","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.audit"}
{"data":{"args":"--user user2","command":"delete","endTime":"Thu, 14 Jan 2021 16:21:27 MST","profile":"minikube,"startTime":"Thu, 14 Jan 2021 16:21:24 MST","user":"user2"},"datacontenttype":"application/json","id":"5b88b158-b9c4-4a25-b3db-fde1eb81563c","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.audit"}

Pretty-print of entry

{
  "data": {
    "args": "--user test123 --alsologtostderr",
    "command": "start",
    "endTime": "Thu, 14 Jan 2021 16:21:04 MST",
    "profile": "minikube",
    "startTime": "Thu, 14 Jan 2021 16:20:18 MST",
    "user": "testUser"
  },
  "datacontenttype": "application/json",
  "id": "042ad16a-79fe-461d-aec7-375c413c52f8",
  "source": "https://minikube.sigs.k8s.io/",
  "specversion": "1.0",
  "type": "io.k8s.sigs.minikube.audit"
}

[k8s-ci-robot]

Hi @spowelljr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

additionally, I am curious does this design allow us to ban one of the commands from auditing ?
for example in some 3rd party tool they call "minikube status" every second, this could result in recording a large audit footprint just for status.

maybe we could either disable it for not intrusive operations such as "status" or "version"

[spowelljr]

additionally, I am curious does this design allow us to ban one of the commands from auditing ?
for example in some 3rd party tool they call "minikube status" every second, this could result in recording a large audit footprint just for status.

maybe we could either disable it for not intrusive operations such as "status" or "version"

Added functionality to not run on specified commands.

[medyagh]

/ok-to-test

[medyagh]

please add Basic Validaiton for user flag
for example dont allow more than ...X.. Length username.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment