-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new exit code word for when runtime not running #10364
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @hetong07. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
I signed it |
ErrDockerRuntimeNotRunning
error when container commands fail/crash due container runtime is not running.
ErrDockerRuntimeNotRunning
error when container commands fail/crash due container runtime is not running.ErrDockerRuntimeNotRunning
error when container commands fail/crash due to container runtime not running.
ErrDockerRuntimeNotRunning
error when container commands fail/crash due to container runtime not running.ErrContainerRuntimeNotRunning
error when container commands fail/crash due to container runtime not running.
…s some trivil docker commands.
…nning after runtime command fails.
954c088
to
341d377
Compare
ErrContainerRuntimeNotRunning
error when container commands fail/crash due to container runtime not running.
/ok-to-test |
kvm2 Driver |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hetong07, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #10165.
Throws an
ErrContainerRuntimeNotRunning
error when container commands fail/crash due container runtime not running.Before PR
As shown in #10165, if container is not running, it will output crash info.
After PR
Hint user that container is not running.