Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new exit code word for when runtime not running #10364

Merged
merged 7 commits into from
Mar 23, 2021

Conversation

hetong07
Copy link
Contributor

@hetong07 hetong07 commented Feb 4, 2021

Fixes #10165.

Throws an ErrContainerRuntimeNotRunning error when container commands fail/crash due container runtime not running.

Before PR
As shown in #10165, if container is not running, it will output crash info.

After PR
Hint user that container is not running.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @hetong07. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2021
@hetong07 hetong07 marked this pull request as draft February 4, 2021 06:29
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@hetong07 hetong07 marked this pull request as ready for review February 4, 2021 06:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2021
pkg/minikube/bootstrapper/bsutil/kubeadm.go Outdated Show resolved Hide resolved
pkg/minikube/bootstrapper/bsutil/kubeadm.go Outdated Show resolved Hide resolved
pkg/minikube/bootstrapper/bsutil/kubeadm.go Outdated Show resolved Hide resolved
@hetong07 hetong07 requested a review from medyagh February 4, 2021 22:53
@hetong07
Copy link
Contributor Author

hetong07 commented Feb 5, 2021

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 5, 2021
@hetong07 hetong07 changed the title Return an new ErrorType when container runtime is not running and fails/crashes its commands. Also hint users to restart the runtime. Return an new ErrorType and hint users to restart container runtime when container runtime is not running and fails/crashes its commands. Feb 5, 2021
@hetong07 hetong07 changed the title Return an new ErrorType and hint users to restart container runtime when container runtime is not running and fails/crashes its commands. Return an new ErrorType and container commands fail/crash due container runtime is not running. Feb 8, 2021
@hetong07 hetong07 changed the title Return an new ErrorType and container commands fail/crash due container runtime is not running. Throws an new ErrorType when container commands fail/crash due container runtime is not running. Feb 8, 2021
@hetong07 hetong07 changed the title Throws an new ErrorType when container commands fail/crash due container runtime is not running. Throws an ErrDockerRuntimeNotRunning error when container commands fail/crash due container runtime is not running. Feb 8, 2021
@hetong07 hetong07 changed the title Throws an ErrDockerRuntimeNotRunning error when container commands fail/crash due container runtime is not running. Throws an ErrDockerRuntimeNotRunning error when container commands fail/crash due to container runtime not running. Feb 8, 2021
pkg/minikube/bootstrapper/bsutil/kubeadm.go Outdated Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
pkg/drivers/kic/oci/errors.go Outdated Show resolved Hide resolved
@hetong07 hetong07 changed the title Throws an ErrDockerRuntimeNotRunning error when container commands fail/crash due to container runtime not running. Throws an ErrContainerRuntimeNotRunning error when container commands fail/crash due to container runtime not running. Feb 8, 2021
@hetong07 hetong07 requested a review from medyagh February 8, 2021 22:02
pkg/minikube/cruntime/cruntime.go Outdated Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
@hetong07 hetong07 requested a review from medyagh February 11, 2021 17:33
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2021
@medyagh medyagh changed the title Throws an ErrContainerRuntimeNotRunning error when container commands fail/crash due to container runtime not running. adding new exit code word for when runtime not running Mar 13, 2021
@medyagh
Copy link
Member

medyagh commented Mar 13, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10364): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10364/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10364/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10364): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10364/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10364/minikube: exec format error

@medyagh medyagh merged commit a05f887 into kubernetes:master Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hetong07, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

none driver: provide solution message when docker not running
6 participants