Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minikube kubectl context switching #10535

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Conversation

BLasan
Copy link
Contributor

@BLasan BLasan commented Feb 20, 2021

fixes #10143

Before PR
minikube -p <profile_name> kubectl -- get ns returned the namespaces in the current context.

After PR
minikube -p <profile_name> kubectl -- get ns will return the namesapces in the given context(--profile).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @BLasan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@BLasan BLasan force-pushed the issue-10143 branch 2 times, most recently from 4ba4ef4 to 23bb4b1 Compare February 20, 2021 10:36
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2021
@BLasan
Copy link
Contributor Author

BLasan commented Feb 20, 2021

@priyawadhwa Build fails. Could you please verify this patch ? I'm confused with this build failure. I hope it's not due to the changes I've made

@BLasan
Copy link
Contributor Author

BLasan commented Feb 20, 2021

@medyagh @priyawadhwa Logs for make cross command in my local machine

$ make cross
GOOS="linux" GOARCH="amd64" \
go build -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.17.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.17.0 -X k8s.io/minikube/pkg/version.gitCommitID="01d47d614139220472a15b0ff39f36ac0e5a582e-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v4" -a -o out/minikube-linux-amd64 k8s.io/minikube/cmd/minikube
GOOS="darwin" GOARCH="amd64" \
go build -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.17.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.17.0 -X k8s.io/minikube/pkg/version.gitCommitID="01d47d614139220472a15b0ff39f36ac0e5a582e-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v4" -a -o out/minikube-darwin-amd64 k8s.io/minikube/cmd/minikube
GOOS="windows" GOARCH="amd64" \
go build -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.17.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.17.0 -X k8s.io/minikube/pkg/version.gitCommitID="01d47d614139220472a15b0ff39f36ac0e5a582e-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v4" -a -o out/minikube-windows-amd64 k8s.io/minikube/cmd/minikube
cp out/minikube-windows-amd64 out/minikube-windows-amd64.exe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BLasan, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2021
@medyagh medyagh merged commit 9d9aecc into kubernetes:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube kubectl --profile does not switch context
4 participants