-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag "--listen-address" for docker and podman driver #10653
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @Loyen. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @Loyen! |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @Loyen for this PR as part of this PR please do the following
1- Add warn to user that if they set this flag,
that minikube is NOT meant to be used for production use and this is not recommended and user should assume all the security risks associated with it
2- Validate the listen flag to be a valid listen address. (so if they pass something not parsable we should exit
valdiateListenFlag(...) {
if not ....
exit.WithUsage
}
2-
Confusing to keep it under "docker & podman" when it's only for docker.
Cheers for the feedback @medyagh!
There's currently a short warning message when you use --listen-address looking like:
I can amend it to have a more informational message.
I've now added validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Loyen do u mind pasting the output of minikube start after this PR in the description of the PR ?
To add more context to the warning message for --listen-address
@medyagh Added the output of start to the description (which includes the "do not use in production" text). |
To stay consistent with other messages. Also moved it above the warning message regarding what IP is set as listen-address to make more sense in the message flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @Loyen just one small thing left
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Loyen, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you @Loyen |
Allow a user to set what IP to listen on when binding ports for the docker and podman driver.
Warns the user when used during start.
Example:
Fixes #8008