Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install losetup from util-linux in the ISO to enable support for VolumeMode=Block PVCs #10704

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Mar 3, 2021

The losetup tool is used by Kubernetes to setup BlockMode volumes.
BusyBox provides a version, but it does not have the -j option.

This was approved and merged earlier through #10255, until #10286 reverted it for unclear reasons.

Fixes: #8284 (again)

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nixpanic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@sharifelgamal
Copy link
Collaborator

@nixpanic, can you rebase against upstream? Once you do, we can properly run our iso tests.

The losetup tool is used by Kubernetes to setup BlockMode volumes.
BusyBox provides a version, but it does not have the `-j` option.
@nixpanic
Copy link
Member Author

nixpanic commented Mar 9, 2021

@nixpanic, can you rebase against upstream? Once you do, we can properly run our iso tests.

Done, thanks.

@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @nixpanic, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Mar 10, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10704): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10704/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10704/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10704): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10704/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10704/minikube: exec format error

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

thank you @nixpanic this will be included on the next release meanwhile feel free to use the latest binary on the head

https://storage.googleapis.com/minikube/latest/minikube-linux-amd64
https://storage.googleapis.com/minikube-builds/master/minikube-linux-amd64

@medyagh medyagh merged commit 025fae0 into kubernetes:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. pr_verified size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

losetup in buildroot VM does not support -j: MapBlockVolume failed: exit status 32
6 participants