Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to exit if unable to cache kubectl #10734

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

afbjorklund
Copy link
Collaborator

Avoid crashing, should there be any issue with downloading and caching kubectl:

Error caching kubectl: download failed: https://storage.googleapis.com/kubernetes-release/release/v1.20.2/bin/linux/amd64/kubectl?checksum=file:https://storage.googleapis.com/kubernetes-release/release/v1.20.2/bin/linux/amd64/kubectl.sha256: getter: &{Ctx:context.Background Src:https://storage.googleapis.com/kubernetes-release/release/v1.20.2/bin/linux/amd64/kubectl?checksum=file:https://storage.googleapis.com/kubernetes-release/release/v1.20.2/bin/linux/amd64/kubectl.sha256 Dst:/root/.minikube/cache/linux/v1.20.2/kubectl.download Pwd: Mode:2 Umask:---------- Detectors:[0x30e2d90 0x30e2d90 0x30e2d90 0x30e2d90 0x30e2d90 0x30e2d90 0x30e2d90] Decompressors:map[bz2:0x30e2d90 gz:0x30e2d90 tar.bz2:0x30e2d90 tar.gz:0x30e2d90 tar.xz:0x30e2d90 tbz2:0x30e2d90 tgz:0x30e2d90 txz:0x30e2d90 xz:0x30e2d90 zip:0x30e2d90] Getters:map[file:0xc000b18c80 http:0xc000b10640 https:0xc000b10660] Dir:false ProgressListener:0x30a6200 Options:[0x1193860]}: invalid checksum: Error downloading checksum file: Get "https://storage.googleapis.com/kubernetes-release/release/v1.20.2/bin/linux/amd64/kubectl.sha256": x509: certificate signed by unknown authority
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1b59910]

@k8s-ci-robot k8s-ci-robot requested review from blueelvis and RA489 March 6, 2021 12:02
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 5beacff into kubernetes:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants