Add a red box around docker desktop registry port #10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you want to process the style string and output it with indentation but without any extra emojis. So add special variants. Also make the enum names more sane for LowIndent, LowIndentBullet (which removes the need of commenting why the enum name was wrong)
To make it harder to miss the notice, with the rest of the emojis Also remove some stray "on" text, but do add "driver" and "port"
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
medyagh
reviewed
Mar 15, 2021
There was a problem hiding this comment.
lets add the same box for the Exit With Advice
the Suggestion is usually not paid attention to, example #10781 (comment)
medyagh
requested changes
Mar 16, 2021
And remove the extra newline inside the box, plus remove the color if not using the emoji.
|
New looks:
Obviously I faked the actual contents, to make it show something on Linux... |
medyagh
approved these changes
Mar 23, 2021
|
looks great ! thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it harder to miss the notice, with the rest of the emojis
Also remove some stray "on" text, but do add "driver" and "port"
Uses https://github.com/Delta456/box-cli-maker
Closes #10781
BEFORE
AFTER