Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect memory being set in the minikube config #11014

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Respect memory being set in the minikube config #11014

merged 2 commits into from
Apr 7, 2021

Conversation

afbjorklund
Copy link
Collaborator

Closes #11012

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from prezha and RA489 April 7, 2021 17:59
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2021
@medyagh
Copy link
Member

medyagh commented Apr 7, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 7, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Apr 7, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 11014): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/11014/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/11014/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 11014): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/11014/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/11014/minikube: exec format error

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@medyagh medyagh merged commit 40d0f5e into kubernetes:master Apr 7, 2021
medyagh
medyagh reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@prezha prezha Awaiting requested review from prezha

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory field of the config file is broken
5 participants
@afbjorklund @k8s-ci-robot @medyagh @minikube-pr-bot @sharifelgamal