Do not allow running darwin/amd64 minikube binary on darwin/arm64 systems #11024

ilya-zuyev · 2021-04-08T18:01:45Z

Before:

ilyaz@mymac --- z/minikube ‹master*➔ ?› » out/minikube-darwin-amd64  start
😄  minikube v1.19.0-beta.0 on Darwin 11.2
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.2 preload ...
    > preloaded-images-k8s-v10-v1...: 491.71 MiB / 491.71 MiB  100.00% 5.45 MiB
    > gcr.io/k8s-minikube/kicbase...: 353.96 MiB / 353.96 MiB  100.00% 3.58 MiB
🔄  Restarting existing docker container for "minikube" ...
🐳  Preparing Kubernetes v1.20.2 on Docker 20.10.3 ...
💢  initialization failed, will try again: wait: /bin/bash -c "sudo env PATH=/var/lib/minikube/binaries/v1.20.2:$PATH kubeadm init --config /var/tmp/minikube/kubeadm.yaml  --ignore-preflight-errors=DirAvailable--etc-kubernetes-manifests,DirAvailable--var-lib-minikube,DirAvailable--var-lib-minikube-etcd,FileAvailable--etc-kubernetes-manifests-kube-scheduler.yaml,FileAvailable--etc-kubernetes-manifests-kube-apiserver.yaml,FileAvailable--etc-kubernetes-manifests-kube-controller-manager.yaml,FileAvailable--etc-kubernetes-manifests-etcd.yaml,Port-10250,Swap,Mem,SystemVerification,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables": Process exited with status 139 from signal SEGV
stdout:

stderr:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped


💣  Error starting cluster: wait: /bin/bash -c "sudo env PATH=/var/lib/minikube/binaries/v1.20.2:$PATH kubeadm init --config /var/tmp/minikube/kubeadm.yaml  --ignore-preflight-errors=DirAvailable--etc-kubernetes-manifests,DirAvailable--var-lib-minikube,DirAvailable--var-lib-minikube-etcd,FileAvailable--etc-kubernetes-manifests-kube-scheduler.yaml,FileAvailable--etc-kubernetes-manifests-kube-apiserver.yaml,FileAvailable--etc-kubernetes-manifests-kube-controller-manager.yaml,FileAvailable--etc-kubernetes-manifests-etcd.yaml,Port-10250,Swap,Mem,SystemVerification,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables": Process exited with status 139 from signal SEGV
stdout:

stderr:
SIGSEGV: segmentation violation
PC=0x0 m=0 sigcode=0

goroutine 1 [running]:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped


😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

❌  Exiting due to GUEST_START: wait: /bin/bash -c "sudo env PATH=/var/lib/minikube/binaries/v1.20.2:$PATH kubeadm init --config /var/tmp/minikube/kubeadm.yaml  --ignore-preflight-errors=DirAvailable--etc-kubernetes-manifests,DirAvailable--var-lib-minikube,DirAvailable--var-lib-minikube-etcd,FileAvailable--etc-kubernetes-manifests-kube-scheduler.yaml,FileAvailable--etc-kubernetes-manifests-kube-apiserver.yaml,FileAvailable--etc-kubernetes-manifests-kube-controller-manager.yaml,FileAvailable--etc-kubernetes-manifests-etcd.yaml,Port-10250,Swap,Mem,SystemVerification,FileContent--proc-sys-net-bridge-bridge-nf-call-iptables": Process exited with status 139 from signal SEGV
stdout:

stderr:
SIGSEGV: segmentation violation
PC=0x0 m=0 sigcode=0

After:

ilyaz@mymac --- z/minikube ‹ilyaz/do_not_run_amd64_on_m1* ?› » out/minikube-darwin-amd64 start

❌  Exiting due to MK_WRONG_BINARY_M1: You are trying to run amd64 binary on M1 system. Please use darwin/arm64 binary instead (Download at https://github.com/kubernetes/minikube/releases/download/v1.19.0-beta.0/minikube-darwin-amd64.

ilya-zuyev · 2021-04-08T18:01:56Z

/ok-to-test

k8s-ci-robot · 2021-04-08T18:02:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ilya-zuyev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/minikube/notify/notify.go

cmd/minikube/cmd/root.go

medyagh · 2021-04-08T18:31:58Z

also PTAL at the lint

minikube-pr-bot · 2021-04-08T18:34:09Z

kvm2 Driver
Times for minikube: 115.7s 114.3s 100.6s
Average time for minikube: 110.2s

Times for Minikube (PR 11024): 102.4s 100.4s 120.3s
Average time for Minikube (PR 11024): 107.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11024) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.0s     | 0.0s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.1s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Downloading Kubernetes                   | 8.9s     |                     |
| v1.20.5 preload ...                        |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 34.6s    | 32.6s               |
| Memory=4000MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.5             | 1.9s     | 1.6s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 1.9s     | 2.4s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 63.6s    | 66.0s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.3s                |
| * Verifying Kubernetes                     | 0.0s     | 0.0s                |
| components...                              |          |                     |
|   - Using image                            | 3.7s     | 3.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.0s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 130.9s 87.9s 91.3s
Average time for minikube: 103.4s

Times for Minikube (PR 11024): 119.9s 139.2s 119.7s
Average time for Minikube (PR 11024): 126.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11024) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.1s     | 0.1s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 6.8s     | 6.6s                |
| (CPUs=2, Memory=4000MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.5             | 95.7s    | 118.9s              |
| on Docker 20.10.5 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.5s     | 0.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.0s     | 0.0s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

ilya-zuyev · 2021-04-08T18:56:45Z

also PTAL at the lint

fixed

minikube-pr-bot · 2021-04-08T19:08:14Z

kvm2 Driver
Times for minikube: 115.7s 121.6s 120.4s
Average time for minikube: 119.2s

Times for Minikube (PR 11024): 113.0s 103.6s 100.8s
Average time for Minikube (PR 11024): 105.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11024) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.0s     | 0.0s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 33.5s    | 32.7s               |
| Memory=4000MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.5             | 1.4s     | 1.9s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 2.7s     | 2.6s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 77.3s    | 63.7s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.4s     | 1.3s                |
| * Verifying Kubernetes                     | 0.0s     | 0.0s                |
| components...                              |          |                     |
|   - Using image                            | 2.8s     | 3.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.0s     | 0.0s                |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 107.7s 160.3s 139.8s
Average time for minikube: 135.9s

Times for Minikube (PR 11024): 87.6s 106.4s 140.3s
Average time for Minikube (PR 11024): 111.4s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11024) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.1s     | 0.1s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.0s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 6.9s     | 6.7s                |
| (CPUs=2, Memory=4000MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.5             | 128.2s   | 103.8s              |
| on Docker 20.10.5 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.5s     | 0.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.0s     | 0.0s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

ilya-zuyev added 2 commits April 7, 2021 15:44

exit if run amd64 binary on M1 cpu

d1431f6

add download link

9a31579

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2021

k8s-ci-robot requested review from afbjorklund and medyagh April 8, 2021 18:02

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021

make linter happy

b2aa1e5

medyagh requested changes Apr 8, 2021

View reviewed changes

pkg/minikube/notify/notify.go Show resolved Hide resolved

cmd/minikube/cmd/root.go Show resolved Hide resolved

ilya-zuyev added 3 commits April 8, 2021 11:37

add unit tests for func DownloadURL(..)

1d1d9f2

Merge branch 'master' into ilyaz/do_not_run_amd64_on_m1

8d8f953

fix imports

6aa7e11

medyagh merged commit 11a2d0a into kubernetes:master Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not allow running darwin/amd64 minikube binary on darwin/arm64 systems #11024

Do not allow running darwin/amd64 minikube binary on darwin/arm64 systems #11024

ilya-zuyev commented Apr 8, 2021

ilya-zuyev commented Apr 8, 2021

k8s-ci-robot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021

ilya-zuyev commented Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021

Do not allow running darwin/amd64 minikube binary on darwin/arm64 systems #11024

Do not allow running darwin/amd64 minikube binary on darwin/arm64 systems #11024

Conversation

ilya-zuyev commented Apr 8, 2021

ilya-zuyev commented Apr 8, 2021

k8s-ci-robot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021

ilya-zuyev commented Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021