recommend kindnet for multinode even for non-docker cr

[prezha]

fixes #11181
fixes #10822

as seen in logs:

...
	I0412 19:29:13.415595   10718 cni.go:81] Creating CNI manager for ""
	I0412 19:29:13.415600   10718 cni.go:137] "kvm2" driver + containerd runtime found, recommending bridge
...
	W0412 19:33:06.922040   10718 out.go:222] X Exiting due to GUEST_START: adding node: cni apply: bridge CNI is incompatible with multi-node clusters
	X Exiting due to GUEST_START: adding node: cni apply: bridge CNI is incompatible with multi-node clusters

or

...
	I0423 23:35:53.975499   16935 cni.go:93] Creating CNI manager for ""
	I0423 23:35:53.975507   16935 cni.go:151] "kvm2" driver + crio runtime found, recommending bridge
	I0423 23:35:53.977976   16935 out.go:157] 
	W0423 23:35:53.978096   16935 out.go:222] X Exiting due to GUEST_START: adding node: cni apply: bridge CNI is incompatible with multi-node clusters
	X Exiting due to GUEST_START: adding node: cni apply: bridge CNI is incompatible with multi-node clusters
...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prezha
To complete the pull request process, please assign ilya-zuyev after the PR has been reviewed.
You can assign the PR to them by writing /assign @ilya-zuyev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

I am confused, is this just moving the code down ?

[prezha]

@medyagh yes, that is correct - before, it would recommend 'bridge' for non-docker cr, even for multinode, and because of

minikube/pkg/minikube/cni/bridge.go

Line 85 in 8ce6326

return fmt.Errorf("bridge CNI is incompatible with multi-node clusters")

it will always fail
this ensures that it first checks if it is multinode and if so - recommend kindnet

[ilya-zuyev]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11182) |
+----------------+----------+---------------------+
| minikube start | 49.7s    | 49.6s               |
| enable ingress | 36.5s    | 36.4s               |
+----------------+----------+---------------------+

Times for minikube start: 50.0s 46.4s 51.0s 50.8s 50.2s
Times for minikube (PR 11182) start: 53.2s 50.4s 50.3s 46.7s 47.3s

Times for minikube ingress: 33.8s 35.2s 34.3s 36.7s 42.3s
Times for minikube (PR 11182) ingress: 35.2s 34.9s 34.2s 42.8s 34.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11182) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.7s               |
| enable ingress | 32.3s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.5s 36.5s 31.5s 29.1s 35.0s
Times for minikube (PR 11182) ingress: 29.0s 37.5s 32.0s 29.5s 28.5s

Times for minikube start: 22.9s 20.9s 21.5s 22.5s 21.0s
Times for minikube (PR 11182) start: 21.5s 21.2s 22.6s 22.4s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11182) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 44.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.8s 46.4s 43.2s 43.0s 47.1s
Times for minikube (PR 11182) start: 46.3s 42.9s 47.5s 42.8s 43.4s

[prezha]

i'll close this one in favour of #11209
/close

[k8s-ci-robot]

@prezha: Closed this PR.

In response to this:

i'll close this one in favour of #11209
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.