-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn about performance for certain versions of kubernetes #11217
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube ingress: 36.5s 43.9s 43.9s 38.9s 38.6s Times for minikube start: 57.9s 53.5s 53.0s 57.7s 58.4s docker driver with docker runtime
Times for minikube (PR 11217) ingress: 29.5s 29.6s 31.6s 29.5s 36.6s Times for minikube start: 22.6s 22.7s 24.7s 23.3s 23.8s docker driver with containerd runtime
Times for minikube start: 49.2s 44.6s 44.5s 43.6s 48.5s |
Looks good to me @sharifelgamal , Thank you for this PR |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube start: 48.8s 47.2s 49.6s 48.2s 47.3s Times for minikube ingress: 34.4s 34.8s 34.3s 34.7s 34.7s docker driver with docker runtime
Times for minikube start: 22.5s 21.9s 21.1s 21.5s 21.8s Times for minikube ingress: 29.5s 31.0s 29.0s 27.6s 27.4s docker driver with containerd runtime
Times for minikube start: 31.4s 47.8s 43.9s 46.6s 42.7s |
Fixes #10327
Before:
After: