Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn about performance for certain versions of kubernetes #11217

Merged
merged 6 commits into from
May 3, 2021

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Apr 27, 2021 β€’

Fixes #10327

Before:

$ minikube start --kubernetes-version=1.18.16
πŸ˜„  minikube v1.19.0 on Darwin 11.2.3
✨  Automatically selected the docker driver. Other choices: hyperkit, ssh
πŸ‘  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
πŸ”₯  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.16 on Docker 20.10.6 ...
    β–ͺ Generating certificates and keys ...
    β–ͺ Booting up control plane ...
    β–ͺ Configuring RBAC rules ...
πŸ”Ž  Verifying Kubernetes components...
    β–ͺ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
πŸ„  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

After:

$ minikube start --kubernetes-version=1.18.16
πŸ˜„  minikube v1.19.0 on Darwin 11.2.3
❗  Kubernetes 1.18.16 has a known performance issue on cluster startup. It might take 2 to 3 minutes for a cluster to start.
❗  For more information, see: https://github.com/kubernetes/kubeadm/issues/2395
✨  Automatically selected the docker driver. Other choices: hyperkit, ssh
πŸ‘  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
πŸ”₯  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.16 on Docker 20.10.6 ...
    β–ͺ Generating certificates and keys ...
    β–ͺ Booting up control plane ...
    β–ͺ Configuring RBAC rules ...
πŸ”Ž  Verifying Kubernetes components...
    β–ͺ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
πŸ„  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2021
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2021
pkg/minikube/reason/k8s.go Outdated Show resolved Hide resolved
pkg/minikube/reason/k8s.go Show resolved Hide resolved
pkg/minikube/reason/k8s.go Outdated Show resolved Hide resolved
pkg/minikube/reason/k8s.go Outdated Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Apr 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 30, 2021
@medyagh medyagh self-requested a review April 30, 2021 13:02
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11217) |
+----------------+----------+---------------------+
| minikube start | 56.1s    | 55.1s               |
| enable ingress | 40.4s    | 38.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 36.5s 43.9s 43.9s 38.9s 38.6s
Times for minikube (PR 11217) ingress: 45.9s 36.4s 37.9s 37.0s 36.4s

Times for minikube start: 57.9s 53.5s 53.0s 57.7s 58.4s
Times for minikube (PR 11217) start: 57.6s 54.6s 54.1s 55.0s 54.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11217) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.8s               |
| enable ingress | 30.9s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 11217) ingress: 29.5s 29.6s 31.6s 29.5s 36.6s
Times for minikube ingress: 31.6s 29.6s 28.1s 31.6s 33.6s

Times for minikube start: 22.6s 22.7s 24.7s 23.3s 23.8s
Times for minikube (PR 11217) start: 23.2s 23.1s 23.0s 22.5s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11217) |
+----------------+----------+---------------------+
| minikube start | 46.1s    | 46.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 49.2s 44.6s 44.5s 43.6s 48.5s
Times for minikube (PR 11217) start: 48.6s 43.8s 43.8s 47.6s 49.4s

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
pkg/minikube/reason/k8s.go Outdated Show resolved Hide resolved
pkg/minikube/reason/k8s.go Outdated Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented May 3, 2021

Looks good to me @sharifelgamal , Thank you for this PR

@medyagh
Copy link
Member

medyagh commented May 3, 2021

/lgtm

@medyagh medyagh merged commit c89e84d into kubernetes:master May 3, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11217) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 49.5s               |
| enable ingress | 34.6s    | 36.9s               |
+----------------+----------+---------------------+

Times for minikube start: 48.8s 47.2s 49.6s 48.2s 47.3s
Times for minikube (PR 11217) start: 49.6s 48.3s 50.9s 47.0s 51.4s

Times for minikube ingress: 34.4s 34.8s 34.3s 34.7s 34.7s
Times for minikube (PR 11217) ingress: 34.2s 43.7s 36.3s 35.7s 34.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11217) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.5s               |
| enable ingress | 28.9s    | 30.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 21.9s 21.1s 21.5s 21.8s
Times for minikube (PR 11217) start: 21.3s 22.3s 20.3s 21.9s 21.7s

Times for minikube ingress: 29.5s 31.0s 29.0s 27.6s 27.4s
Times for minikube (PR 11217) ingress: 28.5s 28.5s 34.5s 29.5s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11217) |
+----------------+----------+---------------------+
| minikube start | 42.5s    | 45.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 47.8s 43.9s 46.6s 42.7s
Times for minikube (PR 11217) start: 47.3s 44.2s 43.9s 43.2s 47.2s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add solution message for slowdown in k8s 1.20.3 and above.
5 participants