Add auto pause on arm64 image #11743

medyagh · 2021-06-22T21:50:11Z

No description provided.

medyagh · 2021-06-22T21:54:04Z

ok-to-build-image

medyagh · 2021-06-22T23:05:12Z

ok-to-build-image

minikube-bot · 2021-06-22T23:07:19Z

Hi @medyagh, building a new kicbase image failed, with the error below:

Full logs are at https://storage.cloud.google.com/minikube-builds/logs/11743/b82c56c/kic_image_build.txt

medyagh · 2021-06-22T23:09:14Z

ok-to-build-image

medyagh · 2021-06-22T23:28:58Z

ok-to-build-image

medyagh · 2021-06-23T00:01:22Z

ok-to-build-image

minikube-bot · 2021-06-23T00:22:28Z

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

medyagh · 2021-06-23T00:24:12Z

/ok-to-test

minikube-pr-bot · 2021-06-23T01:12:37Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 52.2s    | 51.3s               |
| enable ingress | 35.6s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 54.8s 51.0s 51.1s 52.8s 51.3s
Times for minikube (PR 11743) start: 52.1s 50.9s 51.1s 50.5s 51.9s

Times for minikube ingress: 36.3s 34.2s 35.5s 35.3s 36.9s
Times for minikube (PR 11743) ingress: 35.3s 33.9s 34.3s 33.9s 33.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 26.2s               |
| enable ingress | 29.6s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 21.7s 23.4s 21.6s 22.0s
Times for minikube (PR 11743) start: 41.5s 22.4s 22.7s 21.9s 22.4s

Times for minikube ingress: 28.5s 29.0s 28.5s 30.5s 31.5s
Times for minikube (PR 11743) ingress: 31.0s 29.0s 29.0s 28.5s 32.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 43.1s    | 45.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.6s 43.4s 48.9s 43.8s 46.8s
Times for minikube (PR 11743) start: 43.6s 47.5s 43.1s 43.9s 48.2s

minikube-bot · 2021-06-23T01:32:48Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestKubernetesUpgrade	3.45 (chart)

minikube-bot · 2021-06-23T01:35:18Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestFunctional/parallel/MySQL	0.00 (chart)
TestFunctional/parallel/ServiceCmd	0.00 (chart)
TestFunctional/parallel/TunnelCmd/serial/AccessDirect	0.00 (chart)
TestFunctional/parallel/DashboardCmd	1.18 (chart)
TestScheduledStopUnix	4.71 (chart)

medyagh · 2021-06-23T02:44:02Z

ok-to-build-image

minikube-bot · 2021-06-23T03:08:32Z

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

minikube-bot · 2021-06-23T04:17:02Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestRunningBinaryUpgrade	1.19 (chart)

minikube-bot · 2021-06-23T04:23:35Z

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests	Flake Rate (%)
TestSkaffold	0.00 (chart)

minikube-pr-bot · 2021-06-23T04:25:33Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 49.0s    | 48.1s               |
| enable ingress | 39.5s    | 37.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 42.2s 42.2s 42.1s 35.2s 35.7s
Times for minikube (PR 11743) ingress: 34.7s 36.7s 42.3s 34.8s 36.2s

Times for minikube start: 48.3s 48.1s 53.7s 47.0s 47.7s
Times for minikube (PR 11743) start: 47.1s 50.9s 46.3s 47.2s 48.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 30.5s               |
| enable ingress | 35.1s    | 33.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 20.5s 22.4s 20.4s 21.5s
Times for minikube (PR 11743) start: 64.5s 23.2s 22.0s 21.5s 21.3s

Times for minikube ingress: 33.5s 38.5s 34.5s 31.5s 37.5s
Times for minikube (PR 11743) ingress: 33.5s 32.5s 35.0s 33.0s 34.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 41.9s    | 45.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.6s 43.6s 43.1s 48.0s 43.2s
Times for minikube (PR 11743) start: 48.2s 43.3s 46.9s 44.4s 43.6s

minikube-bot · 2021-06-23T04:45:20Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestAddons/parallel/CSI	1.18 (chart)

…ions

minikube-pr-bot · 2021-06-24T22:19:21Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 48.3s    | 48.4s               |
| enable ingress | 34.5s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 47.4s 50.1s 47.3s 49.8s 46.8s
Times for minikube (PR 11743) start: 48.1s 51.0s 48.4s 45.9s 48.7s

Times for minikube ingress: 35.3s 34.8s 33.7s 34.2s 34.7s
Times for minikube (PR 11743) ingress: 35.2s 33.8s 34.3s 35.2s 35.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.6s               |
| enable ingress | 29.6s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 11743) ingress: 29.0s 28.5s 30.1s 29.5s 32.5s
Times for minikube ingress: 28.5s 32.5s 26.5s 29.5s 31.0s

Times for minikube start: 23.0s 21.9s 22.3s 21.7s 22.7s
Times for minikube (PR 11743) start: 20.6s 21.7s 22.0s 21.5s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 44.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 48.1s 44.0s 43.6s 43.2s
Times for minikube (PR 11743) start: 47.6s 43.2s 43.7s 43.4s 46.6s

minikube-pr-bot · 2021-06-25T18:19:23Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 46.6s               |
| enable ingress | 34.0s    | 34.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 11743) start: 47.2s 46.7s 46.9s 46.3s 46.0s
Times for minikube start: 49.2s 48.3s 47.9s 45.9s 46.8s

Times for minikube ingress: 33.1s 34.2s 34.3s 33.8s 34.7s
Times for minikube (PR 11743) ingress: 34.8s 34.2s 32.8s 35.2s 35.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.8s               |
| enable ingress | 29.4s    | 33.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 11743) start: 21.1s 22.3s 21.4s 22.8s 21.4s
Times for minikube start: 23.1s 21.0s 22.9s 21.0s 21.8s

Times for minikube ingress: 30.0s 28.5s 29.0s 30.0s 29.5s
Times for minikube (PR 11743) ingress: 31.0s 31.5s 30.5s 36.5s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 41.8s    | 45.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.8s 47.8s 43.5s 42.4s 43.4s
Times for minikube (PR 11743) start: 46.8s 43.2s 46.8s 44.2s 47.2s

minikube-bot · 2021-06-25T19:07:27Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestFunctional/parallel/MountCmd	0.00 (chart)

minikube-pr-bot · 2021-06-25T21:30:11Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 47.8s               |
| enable ingress | 39.7s    | 36.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 11743) start: 47.4s 46.6s 49.9s 47.7s 47.2s
Times for minikube start: 51.1s 47.6s 48.2s 52.2s 48.7s

Times for minikube ingress: 34.3s 42.3s 43.7s 35.2s 43.2s
Times for minikube (PR 11743) ingress: 34.3s 39.7s 34.8s 35.2s 37.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.2s               |
| enable ingress | 35.6s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.4s 21.6s 21.5s 22.2s
Times for minikube (PR 11743) start: 22.8s 22.2s 22.4s 22.4s 21.4s

Times for minikube ingress: 33.0s 38.0s 34.5s 34.5s 38.0s
Times for minikube (PR 11743) ingress: 33.0s 34.0s 37.5s 34.5s 33.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11743) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 44.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 49.0s 43.1s 43.0s 43.4s 42.7s
Times for minikube (PR 11743) start: 43.3s 43.0s 43.1s 44.7s 47.6s

ilya-zuyev

lgtm

k8s-ci-robot · 2021-06-25T22:25:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ilya-zuyev,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sharifelgamal · 2021-06-25T22:27:37Z

ok-to-build-image

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2021

k8s-ci-robot requested review from afbjorklund and sharifelgamal June 22, 2021 21:50

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021

medyagh changed the title ~~auto puase arm64~~ Add auto pause on arm64 image Jun 22, 2021

kubernetes deleted a comment from minikube-bot Jun 22, 2021

kubernetes deleted a comment from minikube-bot Jun 23, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 23, 2021

medyagh mentioned this pull request Jun 23, 2021

Flake Chart comment to incude Number of tests #11750

Closed

medyagh added 2 commits June 24, 2021 17:25

auto puase arm64

e8103ca

enable auto-puase on arm64

306fa82

medyagh added 3 commits June 24, 2021 17:25

update makefile

fd4722e

fix make target

ef0ad82

minikube version: new flag --packages to list all included tools vers…

52f9778

…ions

medyagh force-pushed the arm64_auto_pause branch from 1bfd599 to 52f9778 Compare June 24, 2021 21:25

remove unrelated changes

5defd04

unrelated revert

2f9d001

ilya-zuyev approved these changes Jun 25, 2021

View reviewed changes

medyagh merged commit 2468684 into kubernetes:master Jun 25, 2021

sharifelgamal mentioned this pull request Jun 28, 2021

auto-pause: add arm64 support #10599

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add auto pause on arm64 image #11743

Add auto pause on arm64 image #11743

medyagh commented Jun 22, 2021

medyagh commented Jun 22, 2021

medyagh commented Jun 22, 2021

minikube-bot commented Jun 22, 2021 •

edited by medyagh

Loading

medyagh commented Jun 22, 2021

medyagh commented Jun 22, 2021

medyagh commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

medyagh commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

medyagh commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 24, 2021

minikube-pr-bot commented Jun 25, 2021

minikube-bot commented Jun 25, 2021

minikube-pr-bot commented Jun 25, 2021

ilya-zuyev left a comment

k8s-ci-robot commented Jun 25, 2021

sharifelgamal commented Jun 25, 2021

Add auto pause on arm64 image #11743

Add auto pause on arm64 image #11743

Conversation

medyagh commented Jun 22, 2021

medyagh commented Jun 22, 2021

medyagh commented Jun 22, 2021

minikube-bot commented Jun 22, 2021 • edited by medyagh Loading

medyagh commented Jun 22, 2021

medyagh commented Jun 22, 2021

medyagh commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

medyagh commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

medyagh commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 24, 2021

minikube-pr-bot commented Jun 25, 2021

minikube-bot commented Jun 25, 2021

minikube-pr-bot commented Jun 25, 2021

ilya-zuyev left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 25, 2021

sharifelgamal commented Jun 25, 2021

minikube-bot commented Jun 22, 2021 •

edited by medyagh

Loading