Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: support renaming binary to kubectl.exe and running as kubectl #11819

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jun 29, 2021

Closes #11838

We support renaming the minikube binary to kubectl and the binary will run as kubectl. However, we don't support renaming the binary to kubectl.exe on Windows and running as kubectl.

This PR adds support for this and also makes the the Windows test pass.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2021
@spowelljr spowelljr changed the title Fix MinikubeKubectlCmdDirectly test on Windows WIP: Fix MinikubeKubectlCmdDirectly test on Windows Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021
cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
@spowelljr spowelljr force-pushed the fixKubectlDirectCall branch from 7c22929 to fdca7d6 Compare June 30, 2021 20:41
@spowelljr spowelljr changed the title WIP: Fix MinikubeKubectlCmdDirectly test on Windows Support renaming binary to kubectl.exe and running as kubectl Jun 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 30, 2021
@medyagh medyagh changed the title Support renaming binary to kubectl.exe and running as kubectl windows: Support renaming binary to kubectl.exe and running as kubectl Jun 30, 2021
@medyagh medyagh changed the title windows: Support renaming binary to kubectl.exe and running as kubectl windows: support renaming binary to kubectl.exe and running as kubectl Jun 30, 2021
@andriyDev
Copy link
Contributor

/ok-to-test

1 similar comment
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11819) |
+----------------+----------+---------------------+
| minikube start | 49.0s    | 47.3s               |
| enable ingress | 34.4s    | 34.3s               |
+----------------+----------+---------------------+

Times for minikube start: 51.1s 48.2s 48.5s 46.8s 50.3s
Times for minikube (PR 11819) start: 50.8s 46.7s 45.9s 46.6s 46.3s

Times for minikube (PR 11819) ingress: 34.7s 33.8s 35.2s 32.8s 35.2s
Times for minikube ingress: 32.7s 34.2s 34.2s 36.2s 34.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11819) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.0s               |
| enable ingress | 30.5s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 11819) start: 21.6s 22.0s 22.5s 21.1s 23.0s
Times for minikube start: 23.2s 22.4s 21.6s 21.1s 22.0s

Times for minikube ingress: 32.5s 31.5s 27.0s 29.5s 32.0s
Times for minikube (PR 11819) ingress: 28.5s 29.5s 29.5s 32.0s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11819) |
+----------------+----------+---------------------+
| minikube start | 42.6s    | 46.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.7s 47.4s 43.0s 46.9s 44.3s
Times for minikube (PR 11819) start: 47.0s 43.5s 43.1s 47.7s 48.6s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal sharifelgamal merged commit 99ba231 into kubernetes:master Jul 1, 2021
@spowelljr spowelljr deleted the fixKubectlDirectCall branch July 8, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestFunctional/serial/MinikubeKubectlCmdDirectly on Windows
6 participants