Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images on the primary control plane #12149

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

afbjorklund
Copy link
Collaborator

Allow selecting another node using --node

Or continue build on all nodes with --all

Closes #11192

Allow selecting another node using --node

Or continue build on all nodes with --all
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2021
@medyagh
Copy link
Member

medyagh commented Aug 13, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 13, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12149) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 48.2s               |
| enable ingress | 33.7s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube start: 49.0s 46.9s 47.5s 47.6s 47.0s
Times for minikube (PR 12149) start: 48.6s 49.2s 47.6s 48.1s 47.5s

Times for minikube ingress: 31.8s 32.3s 33.7s 37.8s 32.8s
Times for minikube (PR 12149) ingress: 32.7s 32.4s 31.3s 31.9s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12149) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 21.9s               |
| enable ingress | 28.8s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 20.8s 20.8s 21.1s 21.8s 22.3s
Times for minikube (PR 12149) start: 22.7s 21.5s 20.9s 21.4s 23.0s

Times for minikube ingress: 28.4s 27.0s 26.9s 25.9s 35.9s
Times for minikube (PR 12149) ingress: 27.0s 26.9s 25.9s 34.4s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12149) |
+----------------+----------+---------------------+
| minikube start | 40.0s    | 42.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.9s 43.4s 44.2s 36.8s 44.7s
Times for minikube (PR 12149) start: 37.8s 44.7s 43.3s 42.3s 43.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestNetworkPlugins/group/auto/Start (gopogh) 1.24 (chart)
Docker_Linux_containerd TestAddons/parallel/Ingress (gopogh) 1.86 (chart)
KVM_Linux_crio TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 1.89 (chart)
KVM_Linux_crio TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 1.89 (chart)
KVM_Linux_containerd TestDownloadOnly/v1.22.2-rc.0/LogsDuration (gopogh) 2.10 (chart)
Docker_Linux_containerd_arm64 TestErrorSpam/setup (gopogh) 3.25 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/kindnet/NetCatPod (gopogh) 3.60 (chart)
KVM_Linux TestAddons/parallel/Olm (gopogh) 5.19 (chart)
Docker_Linux_containerd TestFunctional/parallel/SaveImage (gopogh) 8.45 (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Hyperkit_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 25.93 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 32.69 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 36.60 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 36.60 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 41.56 (chart)
Hyperkit_macOS TestAddons/parallel/CSI (gopogh) 45.14 (chart)
Hyperkit_macOS TestAddons/parallel/Ingress (gopogh) 45.83 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/Ingress (gopogh) 46.38 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 47.40 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/CSI (gopogh) 47.83 (chart)
Hyperkit_macOS TestAddons/parallel/HelmTiller (gopogh) 52.08 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 66.67 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/bridge/Start (gopogh) 67.53 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 2fd09e1 into kubernetes:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only run minikube image build on control plane by default
5 participants