-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minikube image
commands for pull and tag and push
#12326
Conversation
Needed for testing, but maybe elsewhere as well
Normally this is done as part of image build
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 55.4s 50.7s 52.0s 51.2s 54.7s Times for minikube ingress: 32.4s 40.5s 40.3s 42.4s 43.0s docker driver with docker runtime
Times for minikube start: 24.0s 23.8s 22.4s 24.0s 22.6s Times for minikube ingress: 36.0s 33.6s 40.5s 32.0s 32.1s docker driver with containerd runtime
Times for minikube start: 33.0s 48.3s 43.4s 48.9s 44.0s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are lots of copy and paste in these, so the whole "image" and "machine" is due for an overhaul.
There are also no tests that they actually work, but they are normally not called separately by the user...
Closes #12323
See #12270 (comment)