Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ingress-dns addon and add test #12476

Merged
merged 3 commits into from
Sep 15, 2021
Merged

fix ingress-dns addon and add test #12476

merged 3 commits into from
Sep 15, 2021

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Sep 15, 2021 •
edited
Loading

Fixes #12424
Fixes #12455

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 15, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 48.7s    | 49.7s               |
| enable ingress | 33.2s    | 32.7s               |
+----------------+----------+---------------------+

Times for minikube start: 48.8s 47.8s 49.8s 48.9s 48.2s
Times for minikube (PR 12476) start: 50.3s 49.9s 49.5s 48.0s 50.9s

Times for minikube ingress: 32.3s 31.8s 36.8s 33.3s 31.8s
Times for minikube (PR 12476) ingress: 31.4s 34.8s 31.9s 32.4s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 22.4s               |
| enable ingress | 30.0s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.5s 27.4s 34.9s 33.9s 26.4s
Times for minikube (PR 12476) ingress: 27.4s 26.4s 26.9s 27.5s 26.9s

Times for minikube start: 21.9s 21.2s 21.6s 21.6s 21.3s
Times for minikube (PR 12476) start: 22.1s 21.3s 21.3s 23.0s 24.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 37.1s    | 40.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 26.1s 35.9s 44.3s 35.7s 43.3s
Times for minikube (PR 12476) start: 29.6s 43.0s 43.3s 42.8s 43.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/parallel/Ingress (gopogh) 0.68 (chart)
KVM_Linux TestAddons/parallel/Ingress (gopogh) 2.67 (chart)
Docker_Linux TestAddons/parallel/Ingress (gopogh) 3.23 (chart)
Docker_Linux_containerd TestAddons/parallel/Ingress (gopogh) 5.13 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 10.14 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 17.59 (chart)
Docker_Windows TestAddons/parallel/CSI (gopogh) 18.42 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 19.44 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 25.00 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 28.91 (chart)
Docker_Linux TestAddons/parallel/CSI (gopogh) 29.03 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 34.38 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 40.28 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 50.00 (chart)
Docker_Windows TestFunctional/parallel/LoadImageFromFile (gopogh) 52.78 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 54.17 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 57.81 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 58.59 (chart)
Docker_Windows TestPause/serial/VerifyStatus (gopogh) 59.03 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 59.44 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 60.94 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 64.84 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 79.69 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 91.41 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.4s               |
| enable ingress | 31.4s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 47.3s 50.1s 46.5s 47.8s 46.6s
Times for minikube (PR 12476) start: 50.7s 46.8s 46.5s 46.5s 46.6s

Times for minikube ingress: 31.3s 31.4s 30.7s 31.9s 31.8s
Times for minikube (PR 12476) ingress: 32.2s 31.8s 31.2s 30.8s 33.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.0s               |
| enable ingress | 37.3s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.9s 26.4s 83.0s 24.9s 26.5s
Times for minikube (PR 12476) ingress: 25.9s 29.4s 27.0s 26.9s 33.9s

Times for minikube start: 22.1s 21.0s 21.5s 21.4s 21.4s
Times for minikube (PR 12476) start: 21.8s 20.8s 20.9s 20.6s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 43.4s    | 40.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.7s 42.7s 43.5s 43.5s 43.8s
Times for minikube (PR 12476) start: 43.3s 36.7s 42.9s 36.8s 42.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 50.1s    | 50.0s               |
| enable ingress | 32.4s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube start: 52.1s 48.7s 52.5s 48.8s 48.5s
Times for minikube (PR 12476) start: 47.6s 51.9s 53.1s 48.7s 48.8s

Times for minikube ingress: 32.0s 31.3s 33.3s 31.9s 33.3s
Times for minikube (PR 12476) ingress: 32.3s 32.8s 44.4s 31.4s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.2s               |
| enable ingress | 26.5s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.2s 22.6s 21.4s 21.6s
Times for minikube (PR 12476) start: 22.0s 22.6s 22.9s 21.4s 22.3s

Times for minikube ingress: 27.0s 26.4s 25.5s 27.0s 26.9s
Times for minikube (PR 12476) ingress: 27.5s 27.5s 25.9s 25.9s 34.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12476) |
+----------------+----------+---------------------+
| minikube start | 38.7s    | 44.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 26.0s 44.6s 43.1s 43.2s 36.5s
Times for minikube (PR 12476) start: 44.2s 43.9s 43.7s 43.9s 44.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestSkaffold (gopogh) 2.03 (chart)
Docker_Windows TestFunctional/parallel/SaveImage (gopogh) 4.73 (chart)
KVM_Linux TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh) 5.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 13.33 (chart)
Docker_Windows TestAddons/parallel/CSI (gopogh) 17.72 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 20.95 (chart)
Docker_Windows TestScheduledStopWindows (gopogh) 23.65 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 24.84 (chart)
Docker_Windows TestAddons/parallel/HelmTiller (gopogh) 27.85 (chart)
Docker_Windows TestAddons/parallel/Olm (gopogh) 30.38 (chart)
Docker_Linux_containerd TestAddons/parallel/CSI (gopogh) 32.30 (chart)
Docker_Windows TestFunctional/parallel/LoadImageFromFile (gopogh) 53.38 (chart)
Docker_Windows TestPause/serial/VerifyStatus (gopogh) 58.78 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 59.86 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal sharifelgamal merged commit 6528c79 into kubernetes:master Sep 15, 2021
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 7.98 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.98 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 8.92 (chart)
Docker_Linux TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh) 9.09 (chart)
Docker_Linux_containerd TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh) 13.64 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 21.47 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress addon missing an IngressClass resource ingress-dns no longer works on MacOS in minikube 1.23
5 participants
@sharifelgamal @minikube-pr-bot @k8s-ci-robot @medyagh @spowelljr