Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable windows cleanup cron for now #12703

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Oct 12, 2021

this cron seems to be doing more harm than good right now and we reboot machines after running tests anyway, so just disable the scheduled task until we have a better idea

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2021
@sharifelgamal sharifelgamal changed the title check for more than just the e2e binary for the cleanup cron check for more than just the e2e binary for windows cleanup cron Oct 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 12, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 12, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12703) |
+----------------+----------+---------------------+
| minikube start | 47.2s    | 47.1s               |
| enable ingress | 30.6s    | 30.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 12703) start: 47.9s 48.0s 46.0s 46.2s 47.4s
Times for minikube start: 49.7s 46.6s 46.9s 45.7s 47.1s

Times for minikube (PR 12703) ingress: 30.3s 30.8s 31.2s 30.7s 29.8s
Times for minikube ingress: 31.2s 29.8s 30.3s 31.3s 30.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12703) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.1s               |
| enable ingress | 26.7s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 12703) ingress: 26.9s 25.9s 26.5s 27.0s 26.9s
Times for minikube ingress: 26.9s 25.9s 27.4s 26.4s 26.9s

Times for minikube start: 22.0s 21.9s 22.0s 21.7s 20.8s
Times for minikube (PR 12703) start: 20.8s 21.1s 20.7s 21.1s 21.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12703) |
+----------------+----------+---------------------+
| minikube start | 43.1s    | 43.0s               |
| enable ingress | 29.0s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 42.3s 42.7s 43.0s 43.9s 43.3s
Times for minikube (PR 12703) start: 42.9s 43.4s 43.3s 43.2s 42.3s

Times for minikube (PR 12703) ingress: 31.9s 31.9s 31.9s 31.9s 31.9s
Times for minikube ingress: 17.9s 31.9s 31.9s 31.4s 31.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 9.20 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 17.79 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal changed the title check for more than just the e2e binary for windows cleanup cron WIP: check for more than just the e2e binary for windows cleanup cron Oct 13, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2021
@sharifelgamal sharifelgamal changed the title WIP: check for more than just the e2e binary for windows cleanup cron disable windows cleanup cron for now Oct 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12703) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 47.7s               |
| enable ingress | 31.4s    | 32.4s               |
+----------------+----------+---------------------+

Times for minikube start: 50.1s 49.2s 48.3s 47.8s 47.7s
Times for minikube (PR 12703) start: 47.9s 47.4s 48.1s 47.2s 47.8s

Times for minikube ingress: 32.9s 31.4s 30.3s 31.8s 30.9s
Times for minikube (PR 12703) ingress: 31.3s 32.5s 34.8s 31.9s 31.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12703) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 22.0s               |
| enable ingress | 27.3s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 20.7s 22.1s 22.0s 21.2s
Times for minikube (PR 12703) start: 21.1s 21.7s 22.7s 22.0s 22.6s

Times for minikube ingress: 27.0s 28.0s 26.4s 28.0s 26.9s
Times for minikube (PR 12703) ingress: 26.5s 35.9s 26.5s 26.9s 25.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12703) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 38.5s               |
| enable ingress | 31.6s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 12703) start: 25.4s 43.8s 36.2s 43.7s 43.4s
Times for minikube start: 31.5s 43.6s 44.4s 42.6s 44.1s

Times for minikube ingress: 31.2s 32.9s 32.9s 32.9s 28.0s
Times for minikube (PR 12703) ingress: 34.5s 17.9s 32.5s 32.5s 32.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestOffline (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.61 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 6.13 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 8.70 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit c1ee410 into kubernetes:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants