Add all mount flags to start command #12930

spowelljr · 2021-11-11T17:40:16Z

Implemented all the mount flags from minikube mount into minikube start.

medyagh · 2021-11-11T23:09:03Z

/ok-to-test

minikube-pr-bot · 2021-11-12T00:15:55Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 46.4s               |
| enable ingress | 31.6s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 49.8s 46.3s 48.5s 45.4s 45.8s
Times for minikube (PR 12930) start: 45.6s 47.1s 46.9s 46.5s 46.0s

Times for minikube ingress: 32.2s 30.8s 31.8s 31.3s 31.8s
Times for minikube (PR 12930) ingress: 32.2s 31.8s 33.2s 29.7s 31.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.3s    | 21.0s               |
| enable ingress | 28.8s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 21.0s 21.3s 21.9s 20.1s
Times for minikube (PR 12930) start: 20.6s 21.0s 21.7s 20.7s 21.3s

Times for minikube ingress: 26.4s 27.4s 34.9s 27.4s 28.0s
Times for minikube (PR 12930) ingress: 26.9s 27.4s 26.4s 26.9s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 38.7s    | 41.0s               |
| enable ingress | 29.9s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 28.7s 41.3s 41.5s 41.6s 40.5s
Times for minikube (PR 12930) start: 41.3s 41.4s 40.1s 41.1s 41.1s

Times for minikube (PR 12930) ingress: 28.4s 32.0s 17.4s 17.4s 21.9s
Times for minikube ingress: 35.2s 31.9s 27.4s 27.4s 27.4s

minikube-pr-bot · 2021-11-12T01:32:55Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestNetworkPlugins/group/auto/DNS (gopogh)	3.12 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	3.54 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	3.54 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	3.77 (chart)
Docker_macOS	TestNetworkPlugins/group/false/DNS (gopogh)	5.21 (chart)
Docker_Windows	TestPause/serial/Pause (gopogh)	7.96 (chart)
Docker_Windows	TestPause/serial/VerifyStatus (gopogh)	7.96 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	11.39 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	13.27 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	15.92 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	15.93 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	19.83 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/DNS (gopogh)	21.62 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	22.41 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	24.53 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/DNS (gopogh)	29.63 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	30.19 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	35.85 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	69.79 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	70.80 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/DNS (gopogh)	72.62 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	75.22 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	81.08 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartNoArgs (gopogh)	81.82 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/DNS (gopogh)	82.88 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	83.19 (chart)
Docker_macOS	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	98.47 (chart)
Docker_Windows	TestMountStart/serial/RestartStopped (gopogh)	100.00 (chart)
Docker_Windows	TestMountStart/serial/StartWithMountFirst (gopogh)	100.00 (chart)
Docker_Windows	TestMountStart/serial/StartWithMountSecond (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-11-20T02:06:44Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 46.3s    | 45.8s               |
| enable ingress | 31.5s    | 30.8s               |
+----------------+----------+---------------------+

Times for minikube start: 47.2s 45.3s 46.2s 45.7s 47.0s
Times for minikube (PR 12930) start: 45.1s 45.5s 46.4s 46.0s 45.9s

Times for minikube ingress: 32.2s 31.2s 31.3s 31.2s 31.7s
Times for minikube (PR 12930) ingress: 30.7s 30.7s 30.7s 30.6s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 21.1s               |
| enable ingress | 26.4s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 21.0s 20.7s 20.7s 20.7s
Times for minikube (PR 12930) start: 20.2s 21.3s 22.0s 20.4s 21.7s

Times for minikube ingress: 26.4s 25.9s 26.9s 26.9s 25.9s
Times for minikube (PR 12930) ingress: 25.4s 26.4s 33.4s 27.9s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 38.5s    | 37.8s               |
| enable ingress | 24.7s    | 31.1s               |
+----------------+----------+---------------------+

Times for minikube start: 28.5s 41.3s 40.6s 41.0s 40.9s
Times for minikube (PR 12930) start: 40.6s 41.9s 41.1s 24.5s 40.9s

Times for minikube ingress: 27.4s 31.9s 27.4s 18.4s 18.4s
Times for minikube (PR 12930) ingress: 31.9s 31.9s 31.9s 32.4s 27.4s

minikube-pr-bot · 2021-11-20T03:16:18Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	7.74 (chart)
Docker_Linux_containerd	TestPause/serial/VerifyStatus (gopogh)	7.74 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	10.12 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/DNS (gopogh)	66.34 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	67.62 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	67.62 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-11-22T18:19:41Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 46.7s    | 46.7s               |
| enable ingress | 30.9s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 48.0s 46.4s 45.9s 46.8s 46.2s
Times for minikube (PR 12930) start: 47.4s 46.5s 46.7s 46.1s 46.6s

Times for minikube ingress: 32.2s 31.3s 30.2s 30.2s 30.8s
Times for minikube (PR 12930) ingress: 32.3s 31.8s 31.2s 33.2s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.3s               |
| enable ingress | 28.5s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.1s 21.7s 20.5s 23.0s 22.1s
Times for minikube (PR 12930) start: 21.2s 21.0s 21.8s 21.8s 20.5s

Times for minikube ingress: 27.4s 26.9s 26.9s 26.9s 34.4s
Times for minikube (PR 12930) ingress: 27.4s 26.9s 33.9s 26.4s 27.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 39.1s    | 36.8s               |
| enable ingress | 32.1s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube start: 29.6s 41.2s 41.9s 40.7s 42.3s
Times for minikube (PR 12930) start: 41.1s 36.0s 35.5s 29.9s 41.4s

Times for minikube ingress: 28.9s 32.9s 32.9s 32.9s 32.9s
Times for minikube (PR 12930) ingress: 22.9s 24.4s 25.4s 28.0s 28.9s

minikube-pr-bot · 2021-11-22T20:10:53Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Windows	TestNoKubernetes/serial/StartNoArgs (gopogh)	0.83 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-11-24T01:25:18Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 47.4s    | 47.7s               |
| enable ingress | 32.0s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 47.9s 48.0s 47.2s 46.9s 47.3s
Times for minikube (PR 12930) start: 48.0s 46.8s 48.6s 46.9s 48.3s

Times for minikube ingress: 31.9s 31.3s 32.9s 32.3s 31.9s
Times for minikube (PR 12930) ingress: 31.8s 32.3s 31.9s 33.8s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 22.2s               |
| enable ingress | 30.2s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 20.9s 21.7s 22.1s 21.6s
Times for minikube (PR 12930) start: 22.1s 23.0s 21.9s 22.1s 21.9s

Times for minikube ingress: 27.5s 34.5s 27.5s 34.5s 27.0s
Times for minikube (PR 12930) ingress: 26.0s 27.4s 28.5s 27.0s 26.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 39.5s    | 39.4s               |
| enable ingress | 36.8s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 42.5s 43.4s 44.5s 41.5s
Times for minikube (PR 12930) start: 28.8s 43.4s 41.8s 41.9s 41.2s

Times for minikube ingress: 71.9s 19.9s 27.4s 28.9s 36.0s
Times for minikube (PR 12930) ingress: 28.4s 30.0s 31.9s 29.0s 17.9s

minikube-pr-bot · 2021-11-24T03:09:12Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	3.57 (chart)
Hyper-V_Windows	TestMultiNode/serial/CopyFile (gopogh)	7.97 (chart)
Docker_Windows	TestPause/serial/Pause (gopogh)	17.43 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	22.22 (chart)
Docker_Windows	TestMultiNode/serial/CopyFile (gopogh)	26.61 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	26.61 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr · 2021-11-29T18:49:40Z

Waiting for #13018 to be merged to fix mode failure in tests

minikube-pr-bot · 2021-11-30T22:20:57Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 46.3s    | 46.7s               |
| enable ingress | 30.7s    | 30.8s               |
+----------------+----------+---------------------+

Times for minikube start: 48.6s 45.0s 46.0s 46.1s 46.0s
Times for minikube (PR 12930) start: 46.3s 45.8s 48.4s 46.0s 47.0s

Times for minikube ingress: 30.3s 31.7s 30.7s 30.7s 30.2s
Times for minikube (PR 12930) ingress: 30.2s 30.7s 30.2s 30.3s 32.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.0s    | 21.0s               |
| enable ingress | 28.1s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.3s 20.7s 21.1s 20.7s 21.0s
Times for minikube (PR 12930) start: 20.8s 21.1s 21.5s 21.1s 20.6s

Times for minikube ingress: 25.9s 33.9s 27.4s 27.0s 26.4s
Times for minikube (PR 12930) ingress: 26.9s 26.9s 25.4s 25.9s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 39.2s    | 41.2s               |
| enable ingress | 36.1s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube start: 41.0s 28.3s 44.5s 41.5s 40.8s
Times for minikube (PR 12930) start: 41.6s 41.0s 41.0s 40.6s 41.6s

Times for minikube (PR 12930) ingress: 32.4s 27.9s 32.4s 32.4s 31.9s
Times for minikube ingress: 28.4s 28.9s 58.9s 31.9s 32.4s

minikube-pr-bot · 2021-12-01T00:01:52Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Docker_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Docker_Linux	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	5.39 (chart)
Hyper-V_Windows	TestPause/serial/PauseAgain (gopogh)	6.47 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	31.14 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	36.11 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	36.11 (chart)
Hyper-V_Windows	TestMultiNode/serial/CopyFile (gopogh)	49.64 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/DNS (gopogh)	72.12 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	73.53 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	73.64 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	75.21 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-12-01T19:15:53Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 47.2s               |
| enable ingress | 30.6s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.4s 47.1s 47.7s 46.9s 47.0s
Times for minikube (PR 12930) start: 47.8s 47.1s 45.9s 47.4s 47.6s

Times for minikube ingress: 30.8s 30.4s 30.3s 30.8s 30.8s
Times for minikube (PR 12930) ingress: 32.3s 30.3s 31.8s 31.9s 30.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.2s               |
| enable ingress | 28.2s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 21.4s 22.1s 21.6s 21.0s
Times for minikube (PR 12930) start: 21.3s 20.9s 21.4s 21.7s 20.8s

Times for minikube ingress: 33.9s 25.9s 27.9s 27.5s 25.9s
Times for minikube (PR 12930) ingress: 25.9s 25.9s 26.5s 25.4s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 36.6s    | 39.1s               |
| enable ingress | 26.3s    | 30.5s               |
+----------------+----------+---------------------+

Times for minikube start: 28.5s 40.8s 40.8s 36.3s 36.6s
Times for minikube (PR 12930) start: 29.0s 41.5s 41.2s 42.2s 41.5s

Times for minikube ingress: 30.7s 29.4s 22.4s 24.9s 23.9s
Times for minikube (PR 12930) ingress: 29.0s 32.4s 31.9s 31.9s 27.4s

minikube-pr-bot · 2021-12-01T20:59:07Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyper-V_Windows	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	0.78 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.78 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	0.78 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.79 (chart)
KVM_Linux_containerd	TestPause/serial/VerifyDeletedResources (gopogh)	0.94 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	6.67 (chart)
Docker_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	12.68 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	25.74 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	30.88 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	38.97 (chart)
Hyper-V_Windows	TestMultiNode/serial/CopyFile (gopogh)	55.88 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/DNS (gopogh)	73.53 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	74.44 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	74.77 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	76.32 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	78.95 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartNoArgs (gopogh)	94.19 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-12-03T04:10:54Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.4s               |
| enable ingress | 31.8s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 49.1s 47.2s 46.1s 48.5s 48.0s
Times for minikube (PR 12930) start: 46.9s 47.7s 47.3s 47.1s 48.1s

Times for minikube (PR 12930) ingress: 31.0s 32.4s 30.8s 31.9s 31.4s
Times for minikube ingress: 31.9s 31.8s 31.8s 31.8s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.3s               |
| enable ingress | 30.5s    | 31.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 21.8s 22.1s 21.7s 21.4s
Times for minikube (PR 12930) start: 22.4s 22.3s 22.3s 22.6s 21.9s

Times for minikube ingress: 35.4s 27.9s 34.4s 27.5s 27.4s
Times for minikube (PR 12930) ingress: 27.0s 35.0s 30.4s 34.9s 28.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 38.7s    | 40.5s               |
| enable ingress | 33.8s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 34.9s 32.9s 31.9s 33.0s 36.4s
Times for minikube (PR 12930) ingress: 32.4s 28.5s 25.0s 28.9s 27.9s

Times for minikube start: 25.9s 41.4s 42.4s 42.5s 41.4s
Times for minikube (PR 12930) start: 41.7s 41.8s 36.6s 41.1s 41.3s

minikube-pr-bot · 2021-12-03T04:16:55Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestNetworkPlugins/group/kubenet/NetCatPod (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountFirst (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/ControllerPod (gopogh)	1.09 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	7.64 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/false/Start (gopogh)	8.53 (chart)
Docker_macOS	TestJSONOutput/pause/Command (gopogh)	8.76 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh)	11.88 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh)	11.88 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	11.88 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	11.88 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	12.75 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	20.43 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	29.03 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	31.78 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	36.50 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	36.50 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	39.78 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	40.31 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	46.24 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	53.85 (chart)
Hyper-V_Windows	TestMultiNode/serial/CopyFile (gopogh)	68.22 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	70.97 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	75.27 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	75.40 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	75.51 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	77.36 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	77.78 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-12-07T19:07:03Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 45.4s    | 44.5s               |
| enable ingress | 29.3s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 45.9s 45.1s 45.3s 44.4s 46.4s
Times for minikube (PR 12930) start: 43.9s 45.3s 44.1s 43.9s 45.3s

Times for minikube ingress: 28.6s 30.1s 29.1s 29.1s 29.5s
Times for minikube (PR 12930) ingress: 29.1s 26.6s 30.1s 28.6s 25.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 27.0s    | 26.1s               |
| enable ingress | 34.4s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.8s 26.2s 26.4s 25.6s 26.2s
Times for minikube (PR 12930) start: 27.1s 26.3s 25.9s 25.5s 25.7s

Times for minikube ingress: 21.9s 21.4s 22.0s 22.9s 83.9s
Times for minikube (PR 12930) ingress: 22.9s 22.9s 23.9s 22.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 34.3s    | 37.9s               |
| enable ingress | 33.1s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 30.2s 29.2s 40.7s 30.7s 41.0s
Times for minikube (PR 12930) start: 34.4s 45.2s 29.8s 34.0s 45.9s

Times for minikube (PR 12930) ingress: 28.9s 29.9s 33.4s 29.4s 28.4s
Times for minikube ingress: 33.4s 33.4s 33.4s 33.5s 31.9s

pkg/minikube/node/config.go

minikube-pr-bot · 2021-12-07T20:56:45Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/DNS (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux	TestKubernetesUpgrade (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestRunningBinaryUpgrade (gopogh)	0.61 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	0.62 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	0.62 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	1.67 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	1.67 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	1.83 (chart)
Hyper-V_Windows	TestPause/serial/Pause (gopogh)	2.24 (chart)
Hyper-V_Windows	TestPause/serial/VerifyStatus (gopogh)	2.24 (chart)
KVM_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	2.94 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	5.49 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	5.49 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh)	15.15 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh)	15.15 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	15.15 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	15.15 (chart)
Docker_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	15.75 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

klaases · 2021-12-10T19:53:52Z

cmd/minikube/cmd/start_flags.go

@@ -83,6 +83,15 @@ const (
 	imageRepository         = "image-repository"
 	imageMirrorCountry      = "image-mirror-country"
 	mountString             = "mount-string"
+	mount9PVersion          = "mount-9p-version"
+	mountGID                = "mount-gid"
+	mountIPFlag             = "mount-ip"


Some have "Flag" at the end and some do not. Are all of these flags? Could we drop "Flag" for consistency between these?

mountIP, mountPort & mountType are already defined in mount.go so I had to differentiate them

Alright, works for me.

klaases · 2021-12-10T19:57:47Z

pkg/minikube/node/config.go

+	for _, option := range cc.MountOptions {
+		args = append(args, fmt.Sprintf("--%s", constants.MountOptionsFlag), option)
+	}
+	return args


Are there any cases where flags could possess inconsistent values?

Should we have logic, to say, for example, that mountSize value is out of range (maybe we want to do this in a separate PR).

Yeah, I can add that is a follow up PR, I created an issue

#13142

Makes sense!

test/integration/mount_start_test.go

klaases

Added a few comments, mainly curious about if validating flag values is needed.

minikube-pr-bot · 2021-12-10T20:51:53Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 52.9s    | 52.7s               |
| enable ingress | 32.2s    | 33.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12930) start: 53.0s 50.9s 53.0s 54.5s 52.0s
Times for minikube start: 54.3s 52.9s 52.9s 52.4s 51.9s

Times for minikube ingress: 32.4s 31.9s 32.9s 32.4s 31.4s
Times for minikube (PR 12930) ingress: 33.4s 31.9s 31.9s 31.8s 39.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 24.2s               |
| enable ingress | 31.9s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.5s 35.0s 27.0s 35.5s 26.5s
Times for minikube (PR 12930) ingress: 26.5s 34.0s 28.5s 26.0s 26.6s

Times for minikube start: 25.2s 24.2s 24.0s 24.4s 23.9s
Times for minikube (PR 12930) start: 23.8s 24.8s 24.1s 24.1s 24.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12930) |
+----------------+----------+---------------------+
| minikube start | 40.9s    | 43.9s               |
| enable ingress | 33.8s    | 30.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.5s 34.0s 28.0s 37.0s 36.5s
Times for minikube (PR 12930) ingress: 34.0s 19.0s 33.0s 32.5s 33.5s

Times for minikube start: 30.5s 43.9s 43.5s 43.7s 43.0s
Times for minikube (PR 12930) start: 46.0s 43.8s 43.8s 43.4s 42.8s

sharifelgamal

Thanks for fixing this

k8s-ci-robot · 2021-12-10T22:10:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henrik242, klaases, sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-12-10T22:30:39Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	1.37 (chart)
KVM_Linux	TestNetworkPlugins/group/custom-weave/Start (gopogh)	3.23 (chart)
KVM_Linux	TestNetworkPlugins/group/bridge/Start (gopogh)	4.30 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	4.96 (chart)
KVM_Linux	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	5.38 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountFirst (gopogh)	11.90 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostDelete (gopogh)	11.90 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountSecond (gopogh)	11.90 (chart)
Hyperkit_macOS	TestMountStart/serial/VerifyMountPostStop (gopogh)	12.00 (chart)
Docker_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	12.75 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	38.57 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	40.27 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	40.27 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	50.60 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	54.20 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	54.20 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-12-11T00:32:08Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestNoKubernetes/serial/Start (gopogh)	0.00 (chart)
Docker_Linux	TestNoKubernetes/serial/Stop (gopogh)	0.00 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	50.60 (chart)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2021

k8s-ci-robot requested review from afbjorklund and medyagh November 11, 2021 17:41

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 11, 2021

spowelljr mentioned this pull request Nov 22, 2021

Supporting file mounting with--no-kubernetes flag #13003

Closed

spowelljr mentioned this pull request Nov 24, 2021

mount: Fix --mode not being respected #13018

Merged

henrik242 approved these changes Nov 25, 2021

View reviewed changes

spowelljr force-pushed the addMountFlags branch from 2ae1aa8 to 9439da2 Compare November 30, 2021 21:25

spowelljr force-pushed the addMountFlags branch from dd0eff2 to 4e598b6 Compare December 1, 2021 18:24

spowelljr force-pushed the addMountFlags branch from a19f53b to 8091907 Compare December 7, 2021 18:08

sharifelgamal reviewed Dec 7, 2021

View reviewed changes

pkg/minikube/node/config.go Show resolved Hide resolved

spowelljr added 9 commits December 10, 2021 11:43

add all mount flags to start command

5ddb53f

add tests for new start mount flags

4369ccc

fix ssh

0d33b6f

use octal

ed14104

skip checking mounting flags with Docker

7a01568

give timeout for 9P mount check

8927e2e

added missing import

2910ecf

skip Hyper-V mount details check

331034f

format

7b3377e

spowelljr force-pushed the addMountFlags branch from d3b6ef6 to 7b3377e Compare December 10, 2021 19:44

klaases reviewed Dec 10, 2021

View reviewed changes

fixed test error message

874a1d9

klaases reviewed Dec 10, 2021

View reviewed changes

test/integration/mount_start_test.go Outdated Show resolved Hide resolved

klaases reviewed Dec 10, 2021

View reviewed changes

added const

f8028bc

klaases approved these changes Dec 10, 2021

View reviewed changes

sharifelgamal approved these changes Dec 10, 2021

View reviewed changes

skip checking mode on macOS

3ad2f8d

spowelljr force-pushed the addMountFlags branch from 6fd621c to 3ad2f8d Compare December 10, 2021 23:12

spowelljr merged commit bab9c6f into kubernetes:master Dec 10, 2021

spowelljr deleted the addMountFlags branch December 10, 2021 23:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add all mount flags to start command #12930

Add all mount flags to start command #12930

spowelljr commented Nov 11, 2021

medyagh commented Nov 11, 2021

minikube-pr-bot commented Nov 12, 2021

minikube-pr-bot commented Nov 12, 2021

minikube-pr-bot commented Nov 20, 2021

minikube-pr-bot commented Nov 20, 2021

minikube-pr-bot commented Nov 22, 2021

minikube-pr-bot commented Nov 22, 2021

minikube-pr-bot commented Nov 24, 2021

minikube-pr-bot commented Nov 24, 2021

spowelljr commented Nov 29, 2021

minikube-pr-bot commented Nov 30, 2021

minikube-pr-bot commented Dec 1, 2021

minikube-pr-bot commented Dec 1, 2021

minikube-pr-bot commented Dec 1, 2021

minikube-pr-bot commented Dec 3, 2021

minikube-pr-bot commented Dec 3, 2021

minikube-pr-bot commented Dec 7, 2021

minikube-pr-bot commented Dec 7, 2021

klaases Dec 10, 2021

spowelljr Dec 10, 2021

klaases Dec 10, 2021

klaases Dec 10, 2021

spowelljr Dec 10, 2021

klaases Dec 10, 2021

klaases left a comment

minikube-pr-bot commented Dec 10, 2021

sharifelgamal left a comment

k8s-ci-robot commented Dec 10, 2021

minikube-pr-bot commented Dec 10, 2021

minikube-pr-bot commented Dec 11, 2021

Add all mount flags to start command #12930

Add all mount flags to start command #12930

Conversation

spowelljr commented Nov 11, 2021

medyagh commented Nov 11, 2021

minikube-pr-bot commented Nov 12, 2021

minikube-pr-bot commented Nov 12, 2021

minikube-pr-bot commented Nov 20, 2021

minikube-pr-bot commented Nov 20, 2021

minikube-pr-bot commented Nov 22, 2021

minikube-pr-bot commented Nov 22, 2021

minikube-pr-bot commented Nov 24, 2021

minikube-pr-bot commented Nov 24, 2021

spowelljr commented Nov 29, 2021

minikube-pr-bot commented Nov 30, 2021

minikube-pr-bot commented Dec 1, 2021

minikube-pr-bot commented Dec 1, 2021

minikube-pr-bot commented Dec 1, 2021

minikube-pr-bot commented Dec 3, 2021

minikube-pr-bot commented Dec 3, 2021

minikube-pr-bot commented Dec 7, 2021

minikube-pr-bot commented Dec 7, 2021

klaases Dec 10, 2021

Choose a reason for hiding this comment

spowelljr Dec 10, 2021

Choose a reason for hiding this comment

klaases Dec 10, 2021

Choose a reason for hiding this comment

klaases Dec 10, 2021

Choose a reason for hiding this comment

spowelljr Dec 10, 2021

Choose a reason for hiding this comment

klaases Dec 10, 2021

Choose a reason for hiding this comment

klaases left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented Dec 10, 2021

sharifelgamal left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 10, 2021

minikube-pr-bot commented Dec 10, 2021

minikube-pr-bot commented Dec 11, 2021