Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: Remove --mode flag #13162

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

spowelljr
Copy link
Member

The --mount flag can be confusing to users and they since the change will also change their host folder permissions we're going to remove the flag. If you want to change the folder permission simply change it on your host machine and it will match when in the minikube cluster.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13162) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 46.2s               |
| enable ingress | 30.7s    | 31.0s               |
+----------------+----------+---------------------+

Times for minikube start: 48.6s 46.1s 46.5s 46.6s 47.0s
Times for minikube (PR 13162) start: 46.3s 45.9s 46.2s 46.5s 46.3s

Times for minikube ingress: 29.7s 31.3s 30.7s 31.3s 30.3s
Times for minikube (PR 13162) ingress: 31.2s 30.8s 31.7s 30.7s 30.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13162) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 23.3s               |
| enable ingress | 26.3s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 22.8s 24.9s 22.8s 22.8s
Times for minikube (PR 13162) start: 22.2s 22.4s 24.2s 24.0s 24.0s

Times for minikube ingress: 27.4s 26.5s 25.4s 25.4s 26.9s
Times for minikube (PR 13162) ingress: 25.9s 25.9s 25.9s 25.4s 27.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13162) |
+----------------+----------+---------------------+
| minikube start | 37.6s    | 42.5s               |
| enable ingress | 28.9s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.4s 31.4s 31.4s 27.0s 23.1s
Times for minikube (PR 13162) ingress: 18.4s 22.4s 32.4s 31.4s 31.4s

Times for minikube start: 25.9s 42.0s 41.5s 41.5s 37.3s
Times for minikube (PR 13162) start: 42.3s 41.9s 42.4s 42.7s 43.4s

@sharifelgamal sharifelgamal merged commit ed899db into kubernetes:master Dec 14, 2021
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestOffline (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/bridge/Start (gopogh) 1.75 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 1.75 (chart)
KVM_Linux_containerd TestNoKubernetes/serial/Start (gopogh) 1.75 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 3.54 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 4.42 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 5.31 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 5.31 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 6.45 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 8.73 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 8.87 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 8.87 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 44.19 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 54.35 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 66.67 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 66.96 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr deleted the removeMountModeFlag branch December 14, 2021 17:47
queilawithaQ pushed a commit to queilawithaQ/minikube that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants