-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount: Remove --mode
flag
#13162
mount: Remove --mode
flag
#13162
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube start: 48.6s 46.1s 46.5s 46.6s 47.0s Times for minikube ingress: 29.7s 31.3s 30.7s 31.3s 30.3s docker driver with docker runtime
Times for minikube start: 23.1s 22.8s 24.9s 22.8s 22.8s Times for minikube ingress: 27.4s 26.5s 25.4s 25.4s 26.9s docker driver with containerd runtime
Times for minikube ingress: 31.4s 31.4s 31.4s 27.0s 23.1s Times for minikube start: 25.9s 42.0s 41.5s 41.5s 37.3s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
mount: Remove `--mode` flag
The
--mount
flag can be confusing to users and they since the change will also change their host folder permissions we're going to remove the flag. If you want to change the folder permission simply change it on your host machine and it will match when in the minikube cluster.