-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mount test failing due to duplicate port #13183
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube ingress: 29.1s 28.6s 25.1s 31.0s 30.7s Times for minikube start: 46.7s 43.9s 44.4s 44.1s 44.3s docker driver with docker runtime
Times for minikube start: 42.0s 26.2s 26.5s 26.9s 26.5s Times for minikube ingress: 22.4s 23.9s 21.5s 22.9s 22.9s docker driver with containerd runtime
Times for minikube ingress: 28.9s 33.4s 33.4s 33.4s 33.4s Times for minikube (PR 13183) start: 44.0s 46.2s 46.7s 43.4s 46.8s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
Problem:
TestMountStart/serial/VerifyMountPostDelete
was failing on VM drivers. The cause was we were creating two clusters in the test and assigning the same mount port to each, the problem is when one was terminated it would kill the break the mount for the other because of the duplicate port.Solution:
Use different port for each cluster to prevent the port collision.