Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mount test failing due to duplicate port #13183

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

spowelljr
Copy link
Member

Problem:
TestMountStart/serial/VerifyMountPostDelete was failing on VM drivers. The cause was we were creating two clusters in the test and assigning the same mount port to each, the problem is when one was terminated it would kill the break the mount for the other because of the duplicate port.

Solution:
Use different port for each cluster to prevent the port collision.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2021
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13183) |
+----------------+----------+---------------------+
| minikube start | 44.7s    | 44.8s               |
| enable ingress | 28.9s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.1s 28.6s 25.1s 31.0s 30.7s
Times for minikube (PR 13183) ingress: 29.6s 28.1s 26.6s 30.1s 29.1s

Times for minikube start: 46.7s 43.9s 44.4s 44.1s 44.3s
Times for minikube (PR 13183) start: 44.4s 45.6s 44.6s 44.6s 44.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13183) |
+----------------+----------+---------------------+
| minikube start | 29.6s    | 26.1s               |
| enable ingress | 22.7s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 42.0s 26.2s 26.5s 26.9s 26.5s
Times for minikube (PR 13183) start: 26.3s 25.7s 26.4s 26.1s 26.3s

Times for minikube ingress: 22.4s 23.9s 21.5s 22.9s 22.9s
Times for minikube (PR 13183) ingress: 22.9s 21.9s 21.9s 22.4s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13183) |
+----------------+----------+---------------------+
| minikube start | 44.7s    | 45.4s               |
| enable ingress | 32.5s    | 31.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.9s 33.4s 33.4s 33.4s 33.4s
Times for minikube (PR 13183) ingress: 33.4s 29.9s 29.4s 33.4s 28.9s

Times for minikube (PR 13183) start: 44.0s 46.2s 46.7s 43.4s 46.8s
Times for minikube start: 48.3s 43.6s 44.4s 43.6s 43.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/parallel/Olm (gopogh) 0.00 (chart)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.76 (chart)
Docker_Cloud_Shell TestFunctional/serial/LogsFileCmd (gopogh) 1.69 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 2.83 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 3.88 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 5.71 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 6.11 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/DNS (gopogh) 6.59 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 8.04 (chart)
Docker_macOS TestAddons/parallel/Olm (gopogh) 8.26 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 8.85 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 8.85 (chart)
Docker_Linux TestAddons/parallel/Olm (gopogh) 8.89 (chart)
none_Linux TestAddons/parallel/Olm (gopogh) 9.16 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 9.65 (chart)
Docker_Cloud_Shell TestAddons/parallel/Olm (gopogh) 10.17 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 10.71 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 10.71 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 11.61 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 11.61 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 11.61 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 11.61 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 12.39 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 12.39 (chart)
Docker_Linux_containerd TestAddons/parallel/Olm (gopogh) 14.88 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 22.41 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 23.28 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 23.93 (chart)
KVM_Linux_containerd TestRunningBinaryUpgrade (gopogh) 27.82 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 63.41 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 5738dfb into kubernetes:master Dec 17, 2021
@spowelljr spowelljr deleted the fixHyperkitMount branch December 17, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants