Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIC: Add nerdctl from vendor binary #13254

Closed
wants to merge 4 commits into from

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Dec 28, 2021

Adds nerdctl, for interacting with containerd and buildkitd (when using "containerd" container runtime)

See #13252

$ minikube start --container-runtime containerd
...
$ minikube ssh -- sudo nerdctl -n k8s.io
nerdctl is a command line interface for containerd

Usage:
  nerdctl [flags]
  nerdctl [command]
...

Some +10 MB

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 28, 2021
@afbjorklund afbjorklund changed the title Add nerdctl from vendor binary KIC: Add nerdctl from vendor binary Dec 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2021
@afbjorklund afbjorklund requested a review from medyagh December 28, 2021 18:29
@sharifelgamal

This comment was marked as outdated.

@minikube-bot

This comment was marked as outdated.

@sharifelgamal

This comment was marked as outdated.

@medyagh

This comment was marked as outdated.

@minikube-bot

This comment was marked as outdated.

@afbjorklund

This comment was marked as outdated.

@klaases

This comment was marked as outdated.

@minikube-bot

This comment was marked as outdated.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-image

@minikube-bot

This comment was marked as outdated.

1 similar comment
@minikube-bot

This comment was marked as outdated.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2022
@medyagh
Copy link
Member

medyagh commented Mar 23, 2022

ok-to-build-image

@minikube-bot

This comment was marked as outdated.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2022
@afbjorklund
Copy link
Collaborator Author

I will re-open this for the next iteration (1.27), once the other more important features are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants