Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DOCKER_HOST not being numeric IP #13300

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Support DOCKER_HOST not being numeric IP #13300

merged 3 commits into from
Jan 5, 2022

Conversation

spowelljr
Copy link
Member

Fixes #10158

We always assumed that the IP was going to be numeric, but people are using hostnames and localhost, so adding an IP lookup to get the true IP.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 5, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 46.8s    | 46.4s               |
| enable ingress | 31.1s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.7s 29.7s 30.8s 30.9s 31.3s
Times for minikube (PR 13300) ingress: 32.3s 32.8s 31.4s 32.8s 30.4s

Times for minikube start: 48.1s 46.5s 47.1s 46.7s 45.5s
Times for minikube (PR 13300) start: 45.8s 46.3s 48.0s 45.8s 45.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.2s               |
| enable ingress | 29.5s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 22.4s 22.0s 23.0s 21.2s
Times for minikube (PR 13300) start: 20.8s 22.8s 22.5s 22.5s 22.2s

Times for minikube ingress: 34.9s 25.9s 26.9s 33.9s 26.0s
Times for minikube (PR 13300) ingress: 27.4s 35.4s 33.9s 25.9s 27.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 39.6s    | 42.4s               |
| enable ingress | 22.1s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.0s 42.4s 42.2s 42.4s 41.0s
Times for minikube (PR 13300) start: 42.8s 43.1s 41.4s 42.4s 42.5s

Times for minikube ingress: 28.9s 19.0s 18.5s 21.9s 21.9s
Times for minikube (PR 13300) ingress: 22.0s 22.0s 22.4s 19.5s 28.9s

klaases
klaases approved these changes Jan 5, 2022
View reviewed changes
pkg/minikube/driver/endpoint.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestNoKubernetes/serial/StartWithK8s (gopogh) 0.00 (chart)
Docker_Linux TestNoKubernetes/serial/StartWithStopK8s (gopogh) 0.00 (chart)
Docker_Linux TestOffline (gopogh) 0.00 (chart)
Docker_Linux TestNoKubernetes/serial/StartNoArgs (gopogh) 2.96 (chart)
Docker_Linux TestKubernetesUpgrade (gopogh) 4.55 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 4.55 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 7.79 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 9.23 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 9.23 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 9.23 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 9.23 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Stop (gopogh) 9.23 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 9.74 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 11.45 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 15.88 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 16.47 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 17.53 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 17.56 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 20.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 31.76 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 35.56 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 40.77 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 48.00 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 49.09 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 50.77 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 53.74 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 59.18 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 60.42 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 69.08 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 73.28 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 44.8s    | 44.7s               |
| enable ingress | 29.2s    | 30.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.1s 29.6s 29.1s 28.6s 29.6s
Times for minikube (PR 13300) ingress: 31.1s 29.5s 30.1s 30.1s 29.6s

Times for minikube start: 46.9s 44.4s 44.0s 44.8s 43.9s
Times for minikube (PR 13300) start: 44.0s 44.1s 44.9s 45.1s 45.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 26.9s    | 26.4s               |
| enable ingress | 27.9s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 30.5s 25.5s 26.0s 26.5s 25.9s
Times for minikube (PR 13300) start: 26.3s 25.7s 26.4s 27.3s 26.2s

Times for minikube ingress: 21.9s 22.0s 22.5s 50.4s 22.9s
Times for minikube (PR 13300) ingress: 22.4s 22.9s 22.9s 22.4s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 43.4s               |
| enable ingress | 35.8s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 42.3s 41.0s 46.9s 44.9s
Times for minikube (PR 13300) start: 46.3s 45.8s 41.9s 41.1s 41.9s

Times for minikube ingress: 23.4s 33.4s 53.5s 49.4s 19.4s
Times for minikube (PR 13300) ingress: 29.0s 18.9s 52.9s 23.4s 33.5s

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2022
@spowelljr spowelljr merged commit 5641f9a into kubernetes:master Jan 5, 2022
@spowelljr spowelljr deleted the supportHostnames branch January 5, 2022 23:27
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/serial/LogsFileCmd (gopogh) 3.90 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 9.02 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 9.58 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 19.00 (chart)
Docker_Linux TestStartStop/group/newest-cni/serial/Pause (gopogh) 19.76 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 20.33 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 24.79 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 24.79 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 25.64 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 25.64 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 26.67 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 27.35 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 27.64 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 27.97 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 27.97 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 28.21 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 28.81 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 29.17 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 38.14 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 38.52 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 40.17 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 40.29 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 40.34 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 40.97 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 41.18 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 41.18 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 49.2s    | 48.2s               |
| enable ingress | 31.3s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 13300) start: 46.7s 51.5s 47.8s 47.2s 47.7s
Times for minikube start: 52.7s 47.4s 48.1s 50.0s 48.1s

Times for minikube ingress: 30.8s 30.8s 31.4s 32.4s 30.9s
Times for minikube (PR 13300) ingress: 32.3s 31.0s 31.3s 31.4s 32.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 24.1s    | 23.7s               |
| enable ingress | 28.3s    | 30.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.0s 28.0s 34.0s 26.5s 26.0s
Times for minikube (PR 13300) ingress: 27.0s 35.5s 26.5s 26.5s 35.0s

Times for minikube start: 25.0s 23.5s 23.8s 23.1s 24.9s
Times for minikube (PR 13300) start: 24.0s 23.9s 22.5s 23.5s 24.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13300) |
+----------------+----------+---------------------+
| minikube start | 39.7s    | 42.9s               |
| enable ingress | 23.4s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube start: 27.3s 42.8s 43.1s 43.0s 42.3s
Times for minikube (PR 13300) start: 42.6s 43.5s 42.7s 43.4s 42.5s

Times for minikube ingress: 33.5s 17.5s 23.5s 23.0s 19.5s
Times for minikube (PR 13300) ingress: 22.0s 23.5s 18.5s 22.0s 22.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestAddons/parallel/CSI (gopogh) 0.00 (chart)
none_Linux TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
none_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
none_Linux TestAddons/parallel/Registry (gopogh) 0.00 (chart)
none_Linux TestAddons/serial/GCPAuth (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/DashboardCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.00 (chart)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 1.64 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/EnableAddonAfterStop (gopogh) 1.64 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 1.64 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 1.64 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Stop (gopogh) 1.64 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 4.10 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 4.88 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 9.02 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 9.02 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 17.89 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 31.54 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 33.33 (chart)
Docker_Linux_containerd TestRunningBinaryUpgrade (gopogh) 34.16 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 34.96 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 38.52 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 40.34 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 41.38 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 42.62 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 59.35 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube incorrectly assumes the DOCKER_HOST is always a numeric IP address
5 participants
@spowelljr @minikube-pr-bot @k8s-ci-robot @sharifelgamal @klaases