-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: allow skipping kube-proxy addon on restart #13538
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 55.8s 54.0s 52.5s 53.5s 53.9s Times for minikube ingress: 29.6s 29.7s 29.1s 31.1s 29.7s docker driver with docker runtime
Times for minikube start: 31.8s 27.7s 27.2s 27.2s 27.4s Times for minikube ingress: 22.0s 23.0s 22.0s 22.5s 23.0s docker driver with containerd runtime
Times for minikube (PR 13538) start: 43.4s 41.7s 41.7s 46.1s 47.0s Times for minikube ingress: 23.5s 24.5s 23.0s 19.0s 23.0s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #12389
Added a check to prevent hardcoding initing all kubeadm addons on restart. The
kube-proxy
addon seems to be by far the most common step to skip so only added the singe one. Could be expanded in the future to include more if requested.