Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: allow skipping kube-proxy addon on restart #13538

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

spowelljr
Copy link
Member

Fixes #12389

Added a check to prevent hardcoding initing all kubeadm addons on restart. The kube-proxy addon seems to be by far the most common step to skip so only added the singe one. Could be expanded in the future to include more if requested.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13538) |
+----------------+----------+---------------------+
| minikube start | 53.9s    | 53.8s               |
| enable ingress | 29.9s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube start: 55.8s 54.0s 52.5s 53.5s 53.9s
Times for minikube (PR 13538) start: 53.8s 54.8s 52.9s 53.0s 54.4s

Times for minikube ingress: 29.6s 29.7s 29.1s 31.1s 29.7s
Times for minikube (PR 13538) ingress: 29.7s 29.6s 30.1s 26.7s 30.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13538) |
+----------------+----------+---------------------+
| minikube start | 28.2s    | 27.3s               |
| enable ingress | 22.5s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 31.8s 27.7s 27.2s 27.2s 27.4s
Times for minikube (PR 13538) start: 26.6s 27.4s 28.0s 27.4s 27.0s

Times for minikube ingress: 22.0s 23.0s 22.0s 22.5s 23.0s
Times for minikube (PR 13538) ingress: 22.0s 22.0s 22.5s 22.0s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13538) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 44.0s               |
| enable ingress | 22.6s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 13538) start: 43.4s 41.7s 41.7s 46.1s 47.0s
Times for minikube start: 32.2s 41.9s 43.2s 46.2s 41.9s

Times for minikube ingress: 23.5s 24.5s 23.0s 19.0s 23.0s
Times for minikube (PR 13538) ingress: 24.0s 23.0s 23.0s 19.0s 19.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.00 (chart)
Docker_Windows TestDockerFlags (gopogh) 4.92 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 5.08 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/NetCatPod (gopogh) 8.33 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 10.17 (chart)
Docker_Windows TestCertExpiration (gopogh) 11.48 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 11.86 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 13.10 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 15.48 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 15.48 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 17.86 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 18.64 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 19.05 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 19.48 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 19.48 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 19.48 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 19.51 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 20.73 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 20.73 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 20.73 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 21.62 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 21.62 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 126add0 into kubernetes:master Feb 3, 2022
@spowelljr spowelljr deleted the allowKubeProxySkip branch February 3, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeadm.skip-phases=addon/kube-proxy is not honored when restarting an existing cluster
4 participants