Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icacls error logging #13803

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Mar 16, 2022

We have a user experiencing an issues with icacls #13404. The problem is right now we're only logging the error the command returns which is just exit status 1. The output of the command contains more useful information, that could help with debugging.

For example I did icacls cat123:
Error: exit status 2
Output: cat123: The system cannot find the file specified. Successfully processed 0 files; Failed processing 1 files

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@spowelljr spowelljr changed the title Improve icacls error messaging Improve icacls error logging Mar 16, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13803) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 52.7s               |
| enable ingress | 28.9s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 13803) start: 52.1s 53.1s 52.9s 53.0s 52.2s
Times for minikube start: 55.0s 51.6s 52.8s 52.9s 53.3s

Times for minikube ingress: 29.5s 31.1s 28.1s 29.1s 26.6s
Times for minikube (PR 13803) ingress: 29.2s 30.1s 30.6s 29.5s 30.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13803) |
+----------------+----------+---------------------+
| minikube start | 27.5s    | 26.2s               |
| enable ingress | 22.8s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 32.0s 26.2s 25.9s 27.0s 26.3s
Times for minikube (PR 13803) start: 25.8s 26.9s 26.4s 25.5s 26.3s

Times for minikube ingress: 23.0s 22.9s 22.9s 22.4s 22.9s
Times for minikube (PR 13803) ingress: 21.9s 23.9s 21.9s 22.4s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13803) |
+----------------+----------+---------------------+
| minikube start | 41.8s    | 45.3s               |
| enable ingress | 27.8s    | 21.8s               |
+----------------+----------+---------------------+

Times for minikube start: 32.8s 46.1s 46.2s 41.8s 42.3s
Times for minikube (PR 13803) start: 45.1s 46.0s 46.0s 44.7s 44.6s

Times for minikube (PR 13803) ingress: 19.9s 19.0s 29.4s 19.9s 20.9s
Times for minikube ingress: 23.4s 48.9s 18.9s 23.4s 24.4s

Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestNetworkPlugins/group/auto/Start (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 0.83 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 6.33 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 9.49 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 23.01 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 28.43 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 43.41 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 44.14 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 44.14 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 47.27 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 51.16 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 62.03 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 62.79 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 74.23 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.36 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 79.75 (chart)
Docker_Windows TestAddons/parallel/MetricsServer (gopogh) 86.67 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit d35353e into kubernetes:master Mar 16, 2022
@spowelljr spowelljr deleted the fixIcalsError branch March 16, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants