-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve icacls error logging #13803
Improve icacls error logging #13803
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube (PR 13803) start: 52.1s 53.1s 52.9s 53.0s 52.2s Times for minikube ingress: 29.5s 31.1s 28.1s 29.1s 26.6s docker driver with docker runtime
Times for minikube start: 32.0s 26.2s 25.9s 27.0s 26.3s Times for minikube ingress: 23.0s 22.9s 22.9s 22.4s 22.9s docker driver with containerd runtime
Times for minikube start: 32.8s 46.1s 46.2s 41.8s 42.3s Times for minikube (PR 13803) ingress: 19.9s 19.0s 29.4s 19.9s 20.9s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klaases, sharifelgamal, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have a user experiencing an issues with icacls #13404. The problem is right now we're only logging the error the command returns which is just
exit status 1
. The output of the command contains more useful information, that could help with debugging.For example I did
icacls cat123
:Error:
exit status 2
Output:
cat123: The system cannot find the file specified. Successfully processed 0 files; Failed processing 1 files