Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cni-plugins from 0.8.5 to 0.8.7 #14829

Closed
wants to merge 1 commit into from
Closed

Upgrade cni-plugins from 0.8.5 to 0.8.7 #14829

wants to merge 1 commit into from

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Aug 21, 2022 •
edited
Loading

This is the same version as the kubernetes packages are using,
even though there are newer versions available (0.9.1, 1.1.1).

Add back the source code, in case we go back to building the
cni-plugins properly again in the future (currently: binary).

https://github.com/containernetworking/plugins

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2022
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 21, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 56.6s    | 56.8s               |
| enable ingress | 29.0s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 57.8s 57.5s 55.7s 54.4s 57.3s
Times for minikube (PR 14829) start: 56.7s 57.4s 56.2s 57.7s 55.8s

Times for minikube ingress: 28.6s 29.7s 28.6s 28.7s 29.6s
Times for minikube (PR 14829) ingress: 28.6s 29.6s 25.1s 30.2s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 28.0s    | 27.8s               |
| enable ingress | 22.3s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube start: 27.4s 28.7s 27.7s 28.3s 28.1s
Times for minikube (PR 14829) start: 26.7s 28.0s 27.5s 28.4s 28.4s

Times for minikube ingress: 21.0s 23.5s 22.5s 22.5s 22.0s
Times for minikube (PR 14829) ingress: 24.0s 22.9s 22.5s 23.0s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 28.0s    | 23.9s               |
| enable ingress | 27.1s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 35.0s 23.1s 24.0s 35.1s
Times for minikube (PR 14829) start: 23.5s 23.6s 24.2s 23.7s 24.7s

Times for minikube ingress: 27.5s 27.0s 27.0s 27.0s 27.0s
Times for minikube (PR 14829) ingress: 27.0s 27.0s 27.5s 27.0s 27.0s

@afbjorklund afbjorklund mentioned this pull request Aug 21, 2022
Closed
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 57.0s    | 56.7s               |
| enable ingress | 28.3s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.6s 29.1s 29.2s 29.1s 28.6s
Times for minikube (PR 14829) ingress: 29.2s 29.1s 24.6s 25.6s 29.1s

Times for minikube start: 59.4s 55.7s 56.9s 56.0s 57.0s
Times for minikube (PR 14829) start: 56.5s 56.1s 58.0s 56.2s 56.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 27.6s    | 27.9s               |
| enable ingress | 23.4s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 26.7s 29.4s 27.7s 27.6s 26.8s
Times for minikube (PR 14829) start: 28.7s 27.6s 28.1s 28.0s 27.1s

Times for minikube ingress: 23.0s 22.5s 21.5s 27.0s 23.0s
Times for minikube (PR 14829) ingress: 23.0s 22.5s 24.0s 24.4s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 23.6s    | 23.7s               |
| enable ingress | 27.1s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 23.6s 24.3s 23.7s 23.8s
Times for minikube (PR 14829) start: 24.3s 23.3s 23.4s 24.0s 23.5s

Times for minikube ingress: 26.9s 27.0s 27.0s 27.5s 27.0s
Times for minikube (PR 14829) ingress: 27.0s 28.5s 27.0s 27.5s 27.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 0.00 (chart)
Hyper-V_Windows TestPause/serial/PauseAgain (gopogh) 6.94 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 7.09 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 8.39 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 20.86 (chart)
Docker_Linux_containerd TestOffline (gopogh) 23.93 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 24.54 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 24.54 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 24.54 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 24.54 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 24.54 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 24.54 (chart)
Docker_Linux_containerd TestPreload (gopogh) 24.54 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2022
@afbjorklund
Upgrade cni-plugins from 0.8.5 to 0.8.7
c73aeea 
This is the same version as the kubernetes packages are using,
even though there are newer versions available (0.9.1, 1.1.1).

Add back the source code, in case we go back to building the
cni-plugins properly again in the future (currently: binary).
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 56.5s    | 57.9s               |
| enable ingress | 26.9s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 57.3s 54.7s 59.5s 55.5s 55.7s
Times for minikube (PR 14829) start: 61.4s 57.4s 56.5s 57.8s 56.5s

Times for minikube (PR 14829) ingress: 28.2s 26.2s 29.1s 27.7s 28.7s
Times for minikube ingress: 25.2s 24.6s 26.7s 29.2s 28.6s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14829) |
+-------------------+----------+---------------------+
| minikube start    | 29.0s    | 28.6s               |
| ⚠️  enable ingress | 23.2s    | 34.9s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 31.0s 28.4s 27.5s 29.1s 28.8s
Times for minikube (PR 14829) start: 28.3s 28.4s 28.9s 28.8s 28.4s

Times for minikube ingress: 24.0s 22.5s 24.5s 22.5s 22.5s
Times for minikube (PR 14829) ingress: 22.5s 22.0s 83.0s 24.0s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14829) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 25.1s               |
| enable ingress | 26.7s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.6s 24.0s 24.7s 24.9s 24.6s
Times for minikube (PR 14829) start: 24.7s 25.0s 25.6s 24.9s 25.2s

Times for minikube ingress: 26.0s 27.0s 27.5s 26.0s 27.0s
Times for minikube (PR 14829) ingress: 27.0s 26.0s 27.0s 27.0s 27.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnlyKic (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnly/v1.24.4/preload-exists (gopogh) 0.00 (chart)
Docker_macOS TestCertOptions (gopogh) 3.23 (chart)
Docker_macOS TestDockerFlags (gopogh) 3.23 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 3.23 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 3.23 (chart)
Docker_macOS TestCertExpiration (gopogh) 3.87 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 8.39 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 10.46 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 10.97 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 10.97 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 10.97 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 10.97 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 10.97 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 10.97 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 11.04 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 11.04 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 11.04 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 11.04 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, klaases

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afbjorklund @minikube-pr-bot @minikube-bot @k8s-ci-robot @k8s-triage-robot @klaases