-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO: Update docker, containerd, and cri-dockerd #15541
Conversation
ok-to-build-iso |
Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
@spowelljr do we need to stick to the |
Historically we used the same versions as Docker, to not have to test/verify it... But it was separated, since then.
|
It would be easier to provision different versions, if the container runtimes were separated from eachother. |
/ok-to-test |
+1. Cool, makes sense. Thanks for a quick reply. The reason I bought this up was mainly I was wondering if somehow minikube will be impacted by the issue in v1.16.13. |
Sounds like a good reason to upgrade (I forgot if the Buildroot ISO has swap memory controller or not) But somehow I think that pesky setting is debian-specific ? Anyway, it is enabled by default in recent kernels |
I believe the ISO do have swap memory controller.
Yes (maybe Ubuntu 20.04 as well, need to confirm) so better upgrade I reckon. |
kvm2 driver with docker runtime
Times for minikube start: 52.3s 53.3s 53.4s 51.6s 53.9s Times for minikube ingress: 28.7s 28.2s 29.7s 28.7s 25.2s docker driver with docker runtime
Times for minikube ingress: 19.5s 20.0s 20.9s 22.0s 21.5s Times for minikube start: 23.9s 24.9s 25.2s 25.9s 24.5s docker driver with containerd runtime
Times for minikube start: 21.9s 22.2s 32.7s 21.5s 22.1s Times for minikube ingress: 27.0s 26.4s 26.5s 26.0s 26.0s |
Ah okay, got it! Just for understanding, would upgrading the version here also updates it for [Answer] Found it, kickbase image will use latest available |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
deploy/iso/minikube-iso/arch/x86_64/package/containerd-bin/containerd-bin.hash
Outdated
Show resolved
Hide resolved
ok-to-build-iso |
kvm2 driver with docker runtime
Times for minikube start: 54.1s 55.9s 54.8s 53.2s 55.7s Times for minikube ingress: 26.7s 23.2s 26.7s 25.7s 27.7s docker driver with docker runtime
Times for minikube start: 26.3s 25.9s 24.9s 28.3s 24.8s Times for minikube ingress: 21.0s 21.0s 20.9s 21.4s 19.5s docker driver with containerd runtime
Times for minikube start: 24.7s 22.2s 33.4s 22.6s 22.7s Times for minikube (PR 15541) ingress: 26.5s 25.9s 26.5s 26.5s 26.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
kvm2 driver with docker runtime
Times for minikube (PR 15541) start: 58.1s 55.8s 54.6s 55.9s 54.3s Times for minikube (PR 15541) ingress: 29.1s 28.2s 28.7s 28.2s 26.2s docker driver with docker runtime
Times for minikube start: 24.6s 26.0s 25.8s 25.8s 27.1s Times for minikube ingress: 21.0s 20.5s 21.0s 22.0s 22.5s docker driver with containerd runtime
Times for minikube start: 22.1s 21.8s 22.5s 23.0s 22.2s Times for minikube ingress: 26.5s 26.5s 26.0s 26.5s 26.0s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
a315484
to
a3d4863
Compare
ok-to-build-iso |
ok-to-build-image |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh, mqasimsarfraz, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
kvm2 driver with docker runtime
Times for minikube ingress: 24.6s 25.6s 24.6s 24.6s 25.1s Times for minikube start: 55.9s 56.7s 57.0s 55.2s 55.2s docker driver with docker runtime |
kvm2 driver with docker runtime
Times for minikube start: 58.0s 60.0s 57.5s 58.1s 59.7s Times for minikube ingress: 28.7s 28.7s 27.3s 29.2s 28.2s docker driver with docker runtime
Times for minikube start: 27.7s 26.3s 27.5s 28.5s 30.8s Times for minikube ingress: 22.0s 21.0s 20.0s 21.5s 23.5s docker driver with containerd runtime
Times for minikube start: 22.0s 22.7s 22.7s 33.5s 22.2s Times for minikube ingress: 80.0s 19.5s 19.5s 32.5s 32.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
kvm2 driver with docker runtime
Times for minikube start: 57.2s 59.8s 59.4s 60.7s 59.1s Times for minikube ingress: 29.8s 29.8s 30.3s 29.4s 30.3s docker driver with docker runtime
Times for minikube ingress: 25.0s 22.1s 22.0s 22.0s 21.1s Times for minikube start: 32.0s 29.3s 29.4s 31.2s 27.2s docker driver with containerd runtime
Times for minikube ingress: 79.5s 31.5s 30.5s 33.5s 32.5s Times for minikube start: 24.5s 26.6s 23.2s 23.1s 23.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube ingress: 28.8s 30.2s 28.8s 29.2s 29.3s Times for minikube (PR 15541) start: 54.1s 54.6s 54.4s 54.3s 54.5s docker driver with docker runtime
Times for minikube start: 26.5s 25.0s 27.4s 25.2s 29.9s Times for minikube ingress: 22.5s 21.0s 49.5s 20.5s 22.0s docker driver with containerd runtime
Times for minikube start: 22.3s 21.8s 24.7s 24.7s 22.4s Times for minikube ingress: 32.5s 20.0s 81.0s 32.5s 80.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube start: 55.0s 54.4s 55.2s 57.1s 55.6s Times for minikube ingress: 25.7s 28.7s 28.7s 24.1s 30.1s docker driver with docker runtime
Times for minikube start: 24.8s 26.9s 25.9s 26.1s 25.9s Times for minikube ingress: 22.9s 20.9s 21.9s 81.4s 49.4s docker driver with containerd runtime
Times for minikube start: 21.8s 23.8s 21.9s 21.8s 24.4s Times for minikube ingress: 32.9s 47.9s 19.9s 22.0s 33.5s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
https://docs.docker.com/engine/release-notes/#201022
https://github.com/containerd/containerd/releases/tag/v1.6.15
https://github.com/Mirantis/cri-dockerd/releases/tag/v0.3.0