Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kicbase: Fix install for cri-o #18294

Closed
wants to merge 11 commits into from
Closed

kicbase: Fix install for cri-o #18294

wants to merge 11 commits into from

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Mar 4, 2024 •
edited
Loading

Problem:
HEAD is failing with the following when trying to build kicbase

02:59:09  > [linux/amd64 kicbase 23/47] RUN export ARCH=$(dpkg --print-architecture | sed 's/ppc64el/ppc64le/' | sed 's/armhf/arm-v7/') &&     if [ "$ARCH" != "ppc64le" ] && [ "$ARCH" != "arm-v7" ]; then sh -c "echo 'deb https://downloadcontent.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable:/cri-o:/1.29/xUbuntu_22.04/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable:cri-o:1.29.list" &&     curl -LO https://downloadcontent.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable:/cri-o:/1.29/xUbuntu_22.04/Release.key &&     apt-key add - < Release.key &&     clean-install cri-o cri-o-runc; fi:
02:59:09 
100   146  100   146    0     0    334      0 --:--:-- --:--:-- --:--:--   335
02:59:09 0.736 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
02:59:09 0.778 gpg: no valid OpenPGP data found.

Cause:
They moved cri-o 1.29+ to a new deb repo

cri-o < 1.29: https://downloadcontent.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable:/cri-o:/${CRIO_VERSION}/xUbuntu_22.04/

cri-o 1.29+: https://pkgs.k8s.io/addons:/cri-o:/stable:/${CRIO_VERSION}/deb/

Update crictl repo
We were previously using the old repo for crictl https://downloadcontent.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_22.04/

This repo only has crictl v1.25, so there's a version mismatch from our ISO.

Updated the use the new crictl repo https://pkgs.k8s.io/core:/stable:/${CRICTL_VERSION}/deb/

Also pin the crictl version in the kicbase now

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2024
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 7, 2024
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr spowelljr added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 11, 2024
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18294) |
+----------------+----------+---------------------+
| minikube start | 51.6s    | 50.9s               |
| enable ingress | 24.9s    | 24.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.7s 26.6s 22.6s 23.1s 26.6s
Times for minikube (PR 18294) ingress: 22.6s 25.6s 26.7s 22.7s 23.1s

Times for minikube start: 53.1s 51.7s 49.0s 51.7s 52.4s
Times for minikube (PR 18294) start: 52.7s 52.4s 49.9s 49.3s 50.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18294) |
+----------------+----------+---------------------+
| minikube start | 23.6s    | 23.1s               |
| enable ingress | 20.3s    | 20.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.3s 19.4s 20.3s 21.3s 20.3s
Times for minikube (PR 18294) ingress: 20.4s 21.4s 19.9s 20.4s 20.4s

Times for minikube start: 22.9s 24.2s 22.7s 22.4s 26.0s
Times for minikube (PR 18294) start: 23.6s 22.9s 22.9s 22.7s 23.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18294) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 22.4s               |
| enable ingress | 34.1s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.8s 30.8s 30.8s 47.3s 29.8s
Times for minikube (PR 18294) ingress: 22.8s 21.8s 21.8s 21.8s 23.8s

Times for minikube start: 23.9s 21.9s 23.7s 23.3s 21.1s
Times for minikube (PR 18294) start: 21.8s 24.9s 23.8s 20.7s 20.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestFunctional/parallel/StatusCmd (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CloudSpanner (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/Headlamp (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/InspektorGadget (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/LocalPath (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestForceSystemdEnv (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestForceSystemdFlag (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestJSONOutput/pause/Command (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestJSONOutput/unpause/Command (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestKubernetesUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestPause/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/newest-cni/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_crio TestAddons/parallel/CloudSpanner (gopogh) 0.00 (chart)
Docker_Linux_crio TestAddons/parallel/CSI (gopogh) 0.00 (chart)
Docker_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr mentioned this pull request Mar 12, 2024
Merged
@spowelljr spowelljr closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @k8s-ci-robot @minikube-bot @minikube-pr-bot @medyagh