-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kubernetes-dashboard image version to v1.7.1 #2081
Conversation
@zouyee: GitHub didn't allow me to request PR reviews from the following users: suage, fix, high, cpu. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
=======================================
Coverage 28.92% 28.92%
=======================================
Files 81 81
Lines 5311 5311
=======================================
Hits 1536 1536
Misses 3582 3582
Partials 193 193 Continue to review full report at Codecov.
|
@minikube-bot ok to test |
Do not merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding off on this
It is incorrect/incomplete because since 1.7.0 we tend to use a more secure setup where Dashboard is not using cluster role privileges. YAML files should be updated, but we are still discussing it with the core team. One of @kubernetes/dashboard-maintainers will do it soon. Please close it. |
/cc @r2d4 fixes high cpu suage