Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes-dashboard image version to v1.7.1 #2081

Closed
wants to merge 1 commit into from

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Oct 18, 2017

/cc @r2d4 fixes high cpu suage

@k8s-ci-robot k8s-ci-robot requested a review from r2d4 October 18, 2017 13:01
@k8s-ci-robot
Copy link
Contributor

@zouyee: GitHub didn't allow me to request PR reviews from the following users: suage, fix, high, cpu.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @r2d4 fix high cpu suage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #2081 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2081   +/-   ##
=======================================
  Coverage   28.92%   28.92%           
=======================================
  Files          81       81           
  Lines        5311     5311           
=======================================
  Hits         1536     1536           
  Misses       3582     3582           
  Partials      193      193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3358402...8627740. Read the comment docs.

@r2d4
Copy link
Contributor

r2d4 commented Oct 18, 2017

@minikube-bot ok to test

@maciaszczykm
Copy link
Member

Do not merge it.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off on this

@maciaszczykm
Copy link
Member

maciaszczykm commented Oct 19, 2017

It is incorrect/incomplete because since 1.7.0 we tend to use a more secure setup where Dashboard is not using cluster role privileges. YAML files should be updated, but we are still discussing it with the core team. One of @kubernetes/dashboard-maintainers will do it soon. Please close it.

@r2d4 r2d4 added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 19, 2017
@r2d4 r2d4 closed this Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants