Change the cri-o socket location to upstream default

[surajssd]

Right now the cri-o socket is placed in /var/run/crio.sock, this
commit changes it to /var/run/crio/crio.sock which is similar to
upstream.

Fixes #2261

[minikube-bot]

Can one of the admins verify this patch?

[r2d4]

@minikube-bot ok to test

[r2d4]

lgtm

[surajssd]

@vbatts do you mind reviewing this PR!

[dlorenc]

Note that this will probably "break" if minikube and the ISO mismatch - the old iso will still have the version of crio.conf that's listening on /var/run/crio.sock instead of the new location.

If that's a problem, we could add a symlink. What do you think?

[surajssd]

@dlorenc how do I create the symlink? I mean where should this happen?

[dlorenc]

@dlorenc how do I create the symlink? I mean where should this happen?

Hmm, we might be able to do it with a static rootfs overlay here: https://github.com/kubernetes/minikube/tree/master/deploy/iso/minikube-iso/board/coreos/minikube/rootfs-overlay/var

If you make a relative symlink there, I think it should just work. It would have the drawback of existing before the actual socket (and being a dead link), but would be simple.

The other approach would be to add an ln -s command as ExecStartPost in the unit file.

[vbatts]

possibly. but /run and /var/run are often mounted tmpfs. So anything added to the rootfs will be clobbered.

…

On Mon, Dec 11, 2017 at 11:13 AM dlorenc ***@***.***> wrote: @dlorenc <https://github.com/dlorenc> how do I create the symlink? I mean where should this happen? Hmm, we might be able to do it with a static rootfs overlay here: https://github.com/kubernetes/minikube/tree/master/deploy/iso/minikube-iso/board/coreos/minikube/rootfs-overlay/var If you make a relative symlink there, I *think* it should just work. It would have the drawback of existing before the actual socket (and being a dead link), but would be simple. The other approach would be to add an ln -s command as ExecStartPost in the unit file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2262 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEF6SJOy606tfepb8hYjrn2VkNt97Dwks5s_VSVgaJpZM4QzZ9f> .

[surajssd]

@dlorenc I have made the changes PTAL!