Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-node proposal #2565

Closed
wants to merge 1 commit into from
Closed

Multi-node proposal #2565

wants to merge 1 commit into from

Conversation

pbitty
Copy link
Contributor

@pbitty pbitty commented Feb 22, 2018

This is a more fleshed out proposal based on:

The original prototype notes are a bit messy, so here is a cleaner version.

This is meant as a basic design spec that we can have discussions around, and shape into something we feel is worth building.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pbitty
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: r2d4

Assign the PR to them by writing /assign @r2d4 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@pbitty
Copy link
Contributor Author

pbitty commented Feb 22, 2018

/cc @r2d4

nebril
nebril reviewed Feb 26, 2018
View reviewed changes
docs/proposals/multi-node-cluster.md

### Networking

A multi-node cluster relies on a CNI plugin deployed as a DaemonSet to handle routing between nodes. Minikube installs a default CNI distribution out-of-the-box. This can be disabled, allowing a user to install their own choice of CNI plugin, eg. `--cni-plugin=none`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinki minikube flag for CNI plugin is --network-plugin, not --cni-plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case we may need a different flag than network-plugin, or a change in the semantics of this flag, because here we're talking about setting which CNI plugin to use.

The network-plugin flag just tells localkube (or kubelet) whether to use cni or kubenet,
whereas I am proposing we have a flag that tells minikube which CNI plugin should be installed on the cluster automatically, eg. flannel, calico, weave.

If we let minikube handle installing the CNI plugin, we would want to force the value of this flag to cni, or return an error if the value is not cni.

@pbitty
Copy link
Contributor Author

pbitty commented Mar 6, 2018

@r2d4 Are you available for a call sometime this week or next? @afbjorklund is also interested in participating.

@r2d4
Copy link
Contributor

r2d4 commented Mar 6, 2018

Yep @pbitty. Feel free to ping me in slack to coordinate a time (mrick@)

@medarametlahimabindu
Copy link

Minikube is getting error but after getting error we can rid of how the process we can proceed and we will learn how to proceed

@thedrow thedrow mentioned this pull request Mar 18, 2018
Closed
This was referenced Apr 3, 2018
Closed
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2018
@miry
Copy link

miry commented Jun 6, 2018

keep alive

@codestoned1
Copy link

What is the status on this?

@afbjorklund
Copy link
Collaborator

@zlex7 : as per the actual code (#2539), nobody is currently working on it.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 31, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril left review comments

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pbitty @k8s-ci-robot @minikube-bot @r2d4 @medarametlahimabindu @fejta-bot @miry @codestoned1 @afbjorklund @nebril