Cut release 0.29.0 #3175
Merged
Cut release 0.29.0 #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: balopat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
cncf-cla: yes
tstromberg
reviewed
Sep 27, 2018
CHANGELOG.md
Outdated
| * Change default docker storage driver to overlay2 [#3121](https://github.com/kubernetes/minikube/pull/3121) | ||
| * Add env variable for default ES_JAVA_OPTS [#3086](https://github.com/kubernetes/minikube/pull/3086) | ||
| * fix(cli): `minikube start --mount --mountsting` without write permission [#2671](https://github.com/kubernetes/minikube/pull/2671) | ||
| * Add workaround for dnsmasq and hyperkit users to drivers readme [#3003](https://github.com/kubernetes/minikube/pull/3003) |
There was a problem hiding this comment.
This is just a README update, and not related to the release.
CHANGELOG.md
Outdated
| * Fix vmwarefusion driver [#3029](https://github.com/kubernetes/minikube/pull/3029) | ||
| * Make CoreDNS default addon [#3072](https://github.com/kubernetes/minikube/pull/3072) | ||
| * Update CoreDNS deployment [#3073](https://github.com/kubernetes/minikube/pull/3073) | ||
| * readme: update the script to match executable path [#3051](https://github.com/kubernetes/minikube/pull/3051) |
CHANGELOG.md
Outdated
| - Joao Carlos | ||
| - Kumbirai Tanekha | ||
| - Matt Rickard | ||
| - minikube-bot |
pkg/minikube/cluster/cluster.go
Outdated
| @@ -217,7 +217,7 @@ func createHost(api libmachine.API, config cfg.MachineConfig) (*host.Host, error | |||
|
|
|||
| if config.VMDriver != "none" { | |||
| if err := config.Downloader.CacheMinikubeISOFromURL(config.MinikubeISO); err != nil { | |||
| return nil, errors.Wrap(err, "Error attempting to cache minikube ISO from URL") | |||
| return nil, fmt.Errorf("error attempting to cache minikube ISO from URL (%s): %s", config.MinikubeISO, err) | |||
There was a problem hiding this comment.
okay...I'll remove them...
| @@ -47,7 +47,7 @@ func testClusterStatus(t *testing.T) { | |||
| } | |||
| if status != api.ConditionTrue { | |||
| err := fmt.Errorf("Component %s is not Healthy! Status: %s", i.GetName(), status) | |||
| t.Log("Retrying, %s", err) | |||
| t.Logf("Retrying, %s", err) | |||
There was a problem hiding this comment.
Unrelated fix here too.
tstromberg
approved these changes
Sep 27, 2018
afbjorklund
added a commit
to afbjorklund/minikube
that referenced
this pull request
Sep 29, 2018
0.29.0 Release * tag 'v0.29.0': (77 commits) Cut release 0.29.0 (kubernetes#3175) turning error into a warning log message Bump everything to 1.11. Update docs. Update go-ansiterm. Issue kubernetes#3037 change dependency management to dep inlining deleteNetwork into if statement update dashboard version Fix typo: suppports -> supports adding tstromberg kvm2 driver: fixed documentation link in error text kvm2 driver: be more robust with creating of the network, don't delete the network if it is in use kvm2 driver: generate separate random MACs for default and private network NICs kvm2 driver: separated activating and creating of networks kvm2 driver: fixed private network creation and setup fix: --format outputs any string, --https only subsitute http URL scheme Stay in same line Change default docker storage driver to overlay2 Simplifies Linux installation instructions by using install(1) update ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.