Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrapper.kubeadm: set the kubelet --resolv-conf flag conditionally #3292

Closed
wants to merge 1 commit into from

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Nov 2, 2018

Fix the issue: Install on a system using systemd-resolved leads to broken DNS.
If we don't do this, the coredns pod will restart continuously.

/kind bug

Ref: https://github.com/coredns/coredns/blob/master/plugin/loop/README.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SataQiu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SataQiu
Copy link
Member Author

SataQiu commented Nov 2, 2018

/assign @balopat

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 2, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Nov 6, 2018

/assign @tstromberg

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

2 similar comments
@balopat
Copy link
Contributor

balopat commented Nov 27, 2018

@minikube-bot OK to test

@SataQiu
Copy link
Member Author

SataQiu commented Dec 14, 2018

@minikube-bot OK to test

@SataQiu SataQiu closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants